Bring back old completions as a deprecated method in the LTS

Author: WojciechMazur

compiler/src/dotty/tools/repl/ReplDriver.scala

@@ -162,7 +162,7 @@ class ReplDriver(settings: Array[String],
             /* complete = */ false  // if true adds space when completing
           )
         }
-        val comps = completions(line.cursor, line.line, state)
+        val comps = completionsWithSignatures(line.cursor, line.line, state)
         candidates.addAll(comps.map(_.label).distinct.map(makeCandidate).asJava)
         val lineWord = line.word()
         comps.filter(c => c.label == lineWord && c.symbols.nonEmpty) match
@@ -254,8 +254,23 @@ class ReplDriver(settings: Array[String],
     else
       label
 
+  @deprecated("Use completionsWithSignatures instead", "3.3.4")
+  protected final def completions(cursor: Int, expr: String, state0: State): List[Candidate] =
+    completionsWithSignatures(cursor, expr, state0).map: c =>
+      new Candidate(
+        /* value    = */ c.label,
+        /* displ    = */ stripBackTicks(c.label), // displayed value
+        /* group    = */ null,  // can be used to group completions together
+        /* descr    = */ null,  // TODO use for documentation?
+        /* suffix   = */ null,
+        /* key      = */ null,
+        /* complete = */ false  // if true adds space when completing
+      )
+  end completions
+
+
   /** Extract possible completions at the index of `cursor` in `expr` */
-  protected final def completions(cursor: Int, expr: String, state0: State): List[Completion] =
+  protected final def completionsWithSignatures(cursor: Int, expr: String, state0: State): List[Completion] =
     if expr.startsWith(":") then
       ParseResult.commands.collect {
         case command if command._1.startsWith(expr) => Completion(command._1, "", List())
@@ -274,7 +289,7 @@ class ReplDriver(settings: Array[String],
           try Completion.completions(srcPos)._2 catch case NonFatal(_) => Nil
         }
         .getOrElse(Nil)
-  end completions
+  end completionsWithSignatures
 
   protected def interpret(res: ParseResult, quiet: Boolean = false)(using state: State): State = {
     res match {

compiler/test/dotty/tools/repl/TabcompleteTests.scala

@@ -10,7 +10,7 @@ class TabcompleteTests extends ReplTest {
 
   /** Returns the `(<instance completions>, <companion completions>)`*/
   private def tabComplete(src: String)(implicit state: State): List[String] =
-    completions(src.length, src, state).map(_.value).sorted
+    completionsWithSignatures(src.length, src, state).map(_.label).sorted.distinct
 
   @Test def tabCompleteList = initially {
     val comp = tabComplete("List.r")