Two fixes to transparent handling

and more tests

Author: odersky

compiler/src/dotty/tools/dotc/typer/Inliner.scala

@@ -66,7 +66,9 @@ object Inliner {
       override def transform(tree: Tree)(implicit ctx: Context): Tree =
         super.transform(accessorIfNeeded(tree)) match {
           case tree1 @ Assign(lhs: RefTree, rhs) if lhs.symbol.name.is(InlineAccessorName) =>
-            cpy.Apply(tree1)(useSetter(lhs), rhs :: Nil)
+            val setter = useSetter(lhs)
+            if (inlineSym.isTransparentMethod) tree1 // just generate a setter, but don't integrate it in the tree
+            else cpy.Apply(tree1)(setter, rhs :: Nil)
           case tree1 =>
             tree1
         }
@@ -568,6 +570,18 @@ class Inliner(call: tpd.Tree, rhsToInline: tpd.Tree)(implicit ctx: Context) {
    */
   trait InlineTyping extends Typer {
 
+    override def ensureAccessible(tpe: Type, superAccess: Boolean, pos: Position)(implicit ctx: Context): Type = {
+      tpe match {
+        case tpe @ TypeRef(pre, _) if !tpe.symbol.isAccessibleFrom(pre, superAccess) =>
+          tpe.info match {
+            case TypeAlias(alias) => return ensureAccessible(alias, superAccess, pos)
+            case _ =>
+          }
+        case _ =>
+      }
+      super.ensureAccessible(tpe, superAccess, pos)
+    }
+
     override def typedIf(tree: untpd.If, pt: Type)(implicit ctx: Context) = {
       val cond1 = typed(tree.cond, defn.BooleanType)
       cond1.tpe.widenTermRefExpr match {
@@ -623,18 +637,6 @@ class Inliner(call: tpd.Tree, rhsToInline: tpd.Tree)(implicit ctx: Context) {
   /** A re-typer used for inlined methods */
   private class InlineReTyper extends ReTyper with InlineTyping {
 
-    override def ensureAccessible(tpe: Type, superAccess: Boolean, pos: Position)(implicit ctx: Context): Type = {
-      tpe match {
-        case tpe @ TypeRef(pre, _) if !tpe.symbol.isAccessibleFrom(pre, superAccess) =>
-          tpe.info match {
-            case TypeAlias(alias) => return ensureAccessible(alias, superAccess, pos)
-            case _ =>
-          }
-        case _ =>
-      }
-      super.ensureAccessible(tpe, superAccess, pos)
-    }
-
     override def typedIdent(tree: untpd.Ident, pt: Type)(implicit ctx: Context) =
       tree.asInstanceOf[tpd.Tree] match {
         case InlineableArg(rhs) => inlining.println(i"inline arg $tree -> $rhs"); rhs