Merge pull request #5023 from skvithalani/ReplaceErrorStringWithMessage

Introduce CaseClassCannotExtendsEnum message to replace error string from Checking

Author: Blaisorblade

compiler/src/dotty/tools/dotc/reporting/diagnostic/ErrorMessageID.java

@@ -131,7 +131,8 @@ public enum ErrorMessageID {
     MatchCaseOnlyNullWarningID,
     ImportRenamedTwiceID,
     TypeTestAlwaysSucceedsID,
-    TermMemberNeedsNeedsResultTypeForImplicitSearchID
+    TermMemberNeedsNeedsResultTypeForImplicitSearchID,
+    CaseClassCannotExtendEnumID
     ;
 
     public int errorNumber() {

compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala

@@ -2120,4 +2120,10 @@ object messages {
            |To avoid this error, give `$cycleSym` an explicit type.
            |""".stripMargin
   }
+
+  case class CaseClassCannotExtendEnum(cls: Symbol)(implicit ctx: Context) extends Message(CaseClassCannotExtendEnumID) {
+    override def kind: String = "Syntax"
+    override def msg: String = hl"""normal case $cls in ${cls.owner} cannot extend an enum"""
+    override def explanation: String = ""
+  }
 }

compiler/src/dotty/tools/dotc/typer/Checking.scala

@@ -853,7 +853,7 @@ trait Checking {
       cls.owner.isTerm &&
       (cls.owner.flagsUNSAFE.is(Case) || cls.owner.name == nme.DOLLAR_NEW)
     if (!cdef.mods.isEnumCase && !isEnumAnonCls)
-      ctx.error(em"normal case $cls in ${cls.owner} cannot extend an enum", cdef.pos)
+      ctx.error(CaseClassCannotExtendEnum(cls), cdef.pos)
   }
 
   /** Check that all references coming from enum cases in an enum companion object

compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala

@@ -30,7 +30,9 @@ class ErrorMessagesTests extends ErrorMessagesTest {
         implicit val ctx: Context = ictx
         assertMessageCount(1, messages)
         val errorMsg = messages.head
-        assertEquals("normal case class Bar in package <empty> cannot extend an enum", errorMsg.msg)
+        val CaseClassCannotExtendEnum(cls) :: Nil = messages
+        assertEquals("Bar", cls.name.show)
+        assertEquals("<empty>", cls.owner.name.show)
       }
 
   @Test def typeMismatch =