Micro-optimize SymbolLoader#complete

smarter · smarter · commit 7e1734c3bde9 · 2018-05-10T19:28:44.000+02:00
Avoid checking a setting value in a hot path.
diff --git a/compiler/src/dotty/tools/dotc/core/SymbolLoaders.scala b/compiler/src/dotty/tools/dotc/core/SymbolLoaders.scala
@@ -316,7 +316,7 @@ abstract class SymbolLoader extends LazyType {
     }
     try {
       val start = currentTime
-      if (ctx.settings.YdebugTrace.value)
+      if (Config.tracingEnabled && ctx.settings.YdebugTrace.value)
         trace(s">>>> loading ${root.debugString}", _ => s"<<<< loaded ${root.debugString}") {
           doComplete(root)
         }

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ abstract class SymbolLoader extends LazyType {`
`316`	`316`	`}`
`317`	`317`	`try {`
`318`	`318`	`val start = currentTime`
`319`		`- if (ctx.settings.YdebugTrace.value)`
	`319`	`+ if (Config.tracingEnabled && ctx.settings.YdebugTrace.value)`
`320`	`320`	`trace(s">>>> loading ${root.debugString}", _ => s"<<<< loaded ${root.debugString}") {`
`321`	`321`	`doComplete(root)`
`322`	`322`	`}`