Log sbt output, and close stdin so sbt doesn't block on error

Author: smarter

vscode-dotty/src/extension.ts

@@ -63,7 +63,7 @@ export function activate(context: ExtensionContext) {
     const portFile = path.join(workspaceRoot, ".dotty-ide-dev-port")
     fs.readFile(portFile, (err, port) => {
       if (err) {
-        outputChannel.append(`Unable to parse ${portFile}`)
+        outputChannel.appendLine(`Unable to parse ${portFile}`)
         throw err
       }
 
@@ -224,9 +224,15 @@ function runLanguageServer(coursierPath: string, languageServerArtifactFile: str
 function startNewSbtInstance(log: vscode.OutputChannel, coursierPath: string) {
   fetchWithCoursier(coursierPath, sbtArtifact).then((sbtClasspath) => {
     sbtProcess = cpp.spawn("java", [
+      "-Dsbt.log.noformat=true",
       "-classpath", sbtClasspath,
       "xsbt.boot.Boot"
     ]).childProcess
+
+    // Close stdin, otherwise in case of error sbt will block waiting for the
+    // user input to reload or exit the build.
+    sbtProcess.stdin.end()
+
     sbtProcess.stdout.on('data', data => {
       log.append(data.toString())
     })
@@ -268,11 +274,15 @@ function fetchWithCoursier(coursierPath: string, artifact: string, extra: string
       coursierProc.stdout.on('data', (data: Buffer) => {
         classPath += data.toString().trim()
       })
+      coursierProc.stderr.on('data', (data: Buffer) => {
+        let msg = data.toString().trim()
+        outputChannel.appendLine(msg)
+      })
 
       coursierProc.on('close', (code: number) => {
         if (code != 0) {
           let msg = `Couldn't fetch '${ artifact }' (exit code ${ code }).`
-          outputChannel.append(msg)
+          outputChannel.appendLine(msg)
           throw new Error(msg)
         }
       })