Merge pull request #4250 from dotty-staging/decompile-while-loops

Decompile while loops and remove empty packages

Author: nicolasstucki

compiler/src/dotty/tools/dotc/printing/DecompilerPrinter.scala

@@ -1,12 +1,13 @@
 package dotty.tools.dotc.printing
 
-import dotty.tools.dotc.ast.Trees.{Closure, DefDef, Untyped, ValDef}
+import dotty.tools.dotc.ast.Trees._
 import dotty.tools.dotc.ast.untpd.{PackageDef, Template, TypeDef}
 import dotty.tools.dotc.ast.{Trees, untpd}
 import dotty.tools.dotc.printing.Texts._
 import dotty.tools.dotc.core.Contexts._
 import dotty.tools.dotc.core.Flags._
 import dotty.tools.dotc.core.Symbols._
+import dotty.tools.dotc.core.StdNames._
 
 import scala.language.implicitConversions
 
@@ -16,7 +17,13 @@ class DecompilerPrinter(_ctx: Context) extends RefinedPrinter(_ctx) {
     annots.filter(_.tpe != defn.SourceFileAnnotType)
 
   override protected def blockText[T >: Untyped](trees: List[Trees.Tree[T]]): Text = {
-    super.blockText(trees.filterNot(_.isInstanceOf[Closure[_]]))
+    trees match {
+      case DefDef(_, _, _, _, Trees.If(cond, Trees.Block(body :: Nil, _), _)) :: y :: Nil if y.symbol.name == nme.WHILE_PREFIX =>
+        keywordText("while") ~ " (" ~ toText(cond) ~ ")" ~ toText(body)
+      case DefDef(_, _, _, _, Trees.Block(body :: Nil, Trees.If(cond, _, _))) :: y :: Nil if y.symbol.name == nme.DO_WHILE_PREFIX =>
+        keywordText("do") ~ toText(body) ~ keywordText("while") ~ " (" ~ toText(cond) ~ ")"
+      case _ => super.blockText(trees.filterNot(_.isInstanceOf[Closure[_]]))
+    }
   }
 
   override protected def packageDefText(tree: PackageDef): Text = {
@@ -29,8 +36,10 @@ class DecompilerPrinter(_ctx: Context) extends RefinedPrinter(_ctx) {
       case _ => toTextGlobal(stats, "\n")
     }
     val bodyText =
-      if (currentPrecedence == TopLevelPrec) "\n" ~ statsText else " {" ~ statsText ~ "}"
-    keywordStr("package ") ~ toTextPackageId(tree.pid) ~ bodyText
+      if (tree.pid.symbol.isEmptyPackage) statsText
+      else if (currentPrecedence == TopLevelPrec) "\n" ~ statsText
+      else " {" ~ statsText ~ "}"
+    (keywordStr("package ") ~ toTextPackageId(tree.pid)).provided(!tree.symbol.isEmptyPackage) ~ bodyText
   }
 
   override protected def templateText(tree: TypeDef, impl: Template): Text = {
@@ -40,6 +49,11 @@ class DecompilerPrinter(_ctx: Context) extends RefinedPrinter(_ctx) {
     decl ~~ typeText(nameIdText(tree)) ~ withEnclosingDef(tree) { toTextTemplate(impl) } ~ ""
   }
 
+  override protected def toTextTemplate(impl: Template, ofNew: Boolean = false): Text = {
+    val impl1 = impl.copy(parents = impl.parents.filterNot(_.symbol.maybeOwner == defn.ObjectClass))
+    super.toTextTemplate(impl1, ofNew)
+  }
+
   override protected def defDefToText[T >: Untyped](tree: DefDef[T]): Text = {
     import untpd.{modsDeco => _, _}
     dclTextOr(tree) {

compiler/src/dotty/tools/dotc/printing/RefinedPrinter.scala

@@ -654,7 +654,7 @@ class RefinedPrinter(_ctx: Context) extends PlainPrinter(_ctx) {
 
     val bodyText = "{" ~~ selfText ~~ toTextGlobal(primaryConstrs ::: body, "\n") ~ "}"
 
-    prefix ~ (keywordText(" extends") provided !ofNew) ~~ parentsText ~~ bodyText
+    prefix ~ (keywordText(" extends") provided (!ofNew && parents.nonEmpty)) ~~ parentsText ~~ bodyText
   }
 
   protected def templateText(tree: TypeDef, impl: Template): Text = {

tests/pos/lambda.decompiled

@@ -2,7 +2,7 @@
 out/posTestFromTasty/pos/lambda/foo/Foo.class
 --------------------------------------------------------------------------------
 package foo {
-  class Foo() extends Object() {
+  class Foo() {
     val a: Int => Int =
       {
         (x: Int) => x.*(x)

tests/pos/methodTypes.decompiled

@@ -1,11 +1,9 @@
 ================================================================================
 out/posTestFromTasty/pos/methodTypes/Foo.class
 --------------------------------------------------------------------------------
-package <empty> {
-  class Foo() extends Object() {
-    val x: Int = 1
-    def y: Int = 2
-    def z(): Int = 3
-  }
+class Foo() {
+  val x: Int = 1
+  def y: Int = 2
+  def z(): Int = 3
 }
 --------------------------------------------------------------------------------

tests/pos/simpleCaseObject.decompiled

@@ -2,9 +2,7 @@
 out/posTestFromTasty/pos/simpleCaseObject/foo/Foo.class
 --------------------------------------------------------------------------------
 package foo {
-  case object Foo() extends Object() with _root_.scala.Product {
-    this: foo.Foo.type =>
-
+  case object Foo() extends _root_.scala.Product { this: foo.Foo.type =>
     override def hashCode(): Int = 1045991777
     override def toString(): String = "Foo"
     override def canEqual(that: Any): Boolean = that.isInstanceOf[foo.Foo]

tests/pos/simpleClass-2.decompiled

@@ -9,6 +9,6 @@ package foo {
 out/posTestFromTasty/pos/simpleClass-2/foo/B.class
 --------------------------------------------------------------------------------
 package foo {
-  class B() extends Object() {}
+  class B() {}
 }
 --------------------------------------------------------------------------------

tests/pos/simpleClass.decompiled

@@ -2,7 +2,7 @@
 out/posTestFromTasty/pos/simpleClass/foo/A.class
 --------------------------------------------------------------------------------
 package foo {
-  class A() extends Object() {}
+  class A() {}
 }
 --------------------------------------------------------------------------------
 ================================================================================

tests/pos/simpleDoWhile.decompiled

@@ -0,0 +1,15 @@
+================================================================================
+out/posTestFromTasty/pos/simpleDoWhile/Foo.class
+--------------------------------------------------------------------------------
+class Foo() {
+  def foo: Unit =
+    {
+      var i: Int = 1
+      do
+        {
+          i = 0
+        }
+      while (i.!=(0))
+    }
+}
+--------------------------------------------------------------------------------

tests/pos/simpleDoWhile.scala

@@ -0,0 +1,8 @@
+class Foo {
+  def foo = {
+    var i = 1
+    do {
+      i = 0
+    } while (i != 0)
+  }
+}

tests/pos/simpleWhile.decompiled

@@ -0,0 +1,14 @@
+================================================================================
+out/posTestFromTasty/pos/simpleWhile/Foo.class
+--------------------------------------------------------------------------------
+class Foo() {
+  def foo: Unit =
+    {
+      var i: Int = 1
+      while (i.!=(0))
+        {
+          i = 0
+        }
+    }
+}
+--------------------------------------------------------------------------------