Implement methods in tasty positions

Author: nicolasstucki

compiler/src/dotty/tools/dotc/tasty/internal/Position.scala

@@ -3,5 +3,16 @@ package dotty.tools.dotc.tasty.internal
 import dotty.tools.dotc.util.SourcePosition
 
 private[tasty] class Position(val pos: SourcePosition) extends scala.tasty.Position {
+  override def firstOffset = pos.start
+  override def lastOffset = pos.end
+
+  override def sourceFile = pos.source.file.path
+
+  override def startLine = pos.startLine
+  override def endLine = pos.endLine
+
+  override def startColumn = pos.startColumn
+  override def endColumn = pos.endColumn
+
   override def toString: String = s"Position(${pos.line}, ${pos.column})"
 }

library/src/scala/tasty/Position.scala

@@ -1,3 +1,13 @@
 package scala.tasty
 
-trait Position
+trait Position {
+  def firstOffset: Int
+  def lastOffset: Int
+
+  def sourceFile: String
+
+  def startLine: Int
+  def startColumn: Int
+  def endLine: Int
+  def endColumn: Int
+}

tests/pos/tasty/definitions.scala

@@ -25,7 +25,12 @@ object definitions {
 
 // ====== Positions ==================================
 
-  case class Position(firstOffset: Int, lastOffset: Int)
+  case class Position(firstOffset: Int, lastOffset: Int, sourceFile: String) {
+    def startLine: Int = ???
+    def startColumn: Int = ???
+    def endLine: Int = ???
+    def endColumn: Int = ???
+  }
 
   trait Positioned {
     def pos: Position = ???