Merge pull request #1873 from dotty-staging/fix-#1865

Fix #1865: Compute outer path at right phase

Author: odersky

compiler/src/dotty/tools/dotc/transform/ExplicitOuter.scala

@@ -276,7 +276,8 @@ object ExplicitOuter {
           if (tpe.prefix eq NoPrefix) cls.owner.enclosingClass.thisType
           else tpe.prefix
         case _ =>
-          outerPrefix(tpe.underlying)
+          // Need to be careful to dealias before erasure, otherwise we lose prefixes.
+          outerPrefix(tpe.underlying(ctx.withPhaseNoLater(ctx.erasurePhase)))
       }
     case tpe: TypeProxy =>
       outerPrefix(tpe.underlying)

tests/pos/i1865.scala

@@ -0,0 +1,24 @@
+class AbsCell {
+  type T = Node
+  class Node
+}
+
+object Test {
+  def test: Unit = {
+    val cell = new AbsCell
+    new cell.T
+  }
+}
+
+class AbsCell2 {
+  type T = Node
+  val value: T = value
+  def set(x: T): Unit = {}
+  class Node
+}
+object init {
+  def main = {
+    val cell = new AbsCell2 { val init = new Node }
+    cell set (new cell.T)
+  }
+}