Merge pull request #7950 from dotty-staging/fix-trait-test

Fix #7949: sbt test discovery should not run traits

Author: smarter

compiler/src/dotty/tools/dotc/sbt/ExtractAPI.scala

@@ -583,8 +583,8 @@ private class ExtractAPICollector(implicit val ctx: Context) extends ThunkHolder
 
   def apiModifiers(sym: Symbol): api.Modifiers = {
     val absOver = sym.is(AbsOverride)
-    val abs = sym.is(Abstract) || sym.is(Deferred) || absOver
-    val over = sym.is(Override) || absOver
+    val abs = absOver || sym.isOneOf(Trait | Abstract | Deferred)
+    val over = absOver || sym.is(Override)
     new api.Modifiers(abs, over, sym.is(Final), sym.is(Sealed),
       sym.isOneOf(GivenOrImplicit), sym.is(Lazy), sym.is(Macro), sym.isSuperAccessor)
   }

sbt-dotty/sbt-test/discovery/test-discovery/src/test/scala/AbstractClassTest.scala

@@ -0,0 +1,9 @@
+import org.junit.Test
+import org.junit.Assert.assertEquals
+
+// Test discovery should not pick this up because it's abstract
+abstract class AbstractClassTest {
+  @Test def foo = {
+    ???
+  }
+}

sbt-dotty/sbt-test/discovery/test-discovery/src/test/scala/TraitTest.scala

@@ -0,0 +1,9 @@
+import org.junit.Test
+import org.junit.Assert.assertEquals
+
+// Test discovery should not pick this up because it's a trait
+trait TraitTest {
+  @Test def foo = {
+    ???
+  }
+}