Use EmptyTree for the cond of infinite WhileDo loops.

Such `WhileDo` node have type `Nothing` instead of `Unit`. This is
used in the loops generated by `TailRec` in order not to need some
spurious dead code.

Author: sjrd

compiler/src/dotty/tools/dotc/transform/TailRec.scala

@@ -32,7 +32,7 @@ import reporting.diagnostic.messages.TailrecNotApplicable
  *  {{{
  *  var localForParam1: T1 = param1
  *  ...
- *  while (true) {
+ *  while (<empty>) {
  *    tailResult[ResultType]: {
  *      return {
  *        // original rhs with tail recursive calls transformed (see below)
@@ -60,7 +60,7 @@ import reporting.diagnostic.messages.TailrecNotApplicable
  *  def fact(n: Int, acc: Int): Int = {
  *    var acc$tailLocal1: Int = acc
  *    var n$tailLocal1: Int = n
- *    while (true) {
+ *    while (<empty>) {
  *      tailLabel1[Unit]: {
  *        return {
  *          if (n$tailLocal1 == 0)
@@ -75,7 +75,6 @@ import reporting.diagnostic.messages.TailrecNotApplicable
  *        }
  *      }
  *    }
- *    throw null // unreachable
  *  }
  *  }}}
  *
@@ -163,14 +162,12 @@ class TailRec extends MiniPhase {
             }
 
             Block(
-              initialVarDefs :::
-              WhileDo(Literal(Constant(true)), {
+              initialVarDefs,
+              WhileDo(EmptyTree, {
                 Labeled(transformer.continueLabel.asTerm, {
                   Return(rhsFullyTransformed, origMeth)
                 })
-              }) ::
-              Nil,
-              Throw(Literal(Constant(null))) // unreachable code
+              })
             )
           } else {
             if (mandatory) ctx.error(

compiler/src/dotty/tools/dotc/transform/TreeChecker.scala

@@ -452,6 +452,11 @@ class TreeChecker extends Phase with SymTransformer {
       tree1
     }
 
+    override def typedWhileDo(tree: untpd.WhileDo)(implicit ctx: Context): Tree = {
+      assert((tree.cond ne EmptyTree) || ctx.phase.refChecked, i"invalid empty condition in while at $tree")
+      super.typedWhileDo(tree)
+    }
+
     override def ensureNoLocalRefs(tree: Tree, pt: Type, localSyms: => List[Symbol])(implicit ctx: Context): Tree =
       tree
 

compiler/src/dotty/tools/dotc/typer/TypeAssigner.scala

@@ -486,7 +486,7 @@ trait TypeAssigner {
     tree.withType(defn.NothingType)
 
   def assignType(tree: untpd.WhileDo)(implicit ctx: Context): WhileDo =
-    tree.withType(defn.UnitType)
+    tree.withType(if (tree.cond eq EmptyTree) defn.NothingType else defn.UnitType)
 
   def assignType(tree: untpd.Try, expr: Tree, cases: List[CaseDef])(implicit ctx: Context): Try =
     if (cases.isEmpty) tree.withType(expr.tpe)

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -1127,7 +1127,9 @@ class Typer extends Namer
   }
 
   def typedWhileDo(tree: untpd.WhileDo)(implicit ctx: Context): Tree = track("typedWhileDo") {
-    val cond1 = typed(tree.cond, defn.BooleanType)
+    val cond1 =
+      if (tree.cond eq EmptyTree) EmptyTree
+      else typed(tree.cond, defn.BooleanType)
     val body1 = typed(tree.body, defn.UnitType)
     assignType(cpy.WhileDo(tree)(cond1, body1))
   }