address review

Author: liufengyun

compiler/src/dotty/tools/dotc/transform/IsInstanceOfChecker.scala

@@ -28,9 +28,8 @@ class IsInstanceOfChecker extends MiniPhase {
     }
 
     tree.fun match {
-      case fn: Select if fn.symbol == defn.Any_typeTest =>
-        ensureCheckable(fn.qualifier, tree.args.head)
-      case fn: Select if fn.symbol == defn.Any_isInstanceOf =>
+      case fn: Select
+      if fn.symbol == defn.Any_typeTest || fn.symbol == defn.Any_isInstanceOf =>
         ensureCheckable(fn.qualifier, tree.args.head)
       case _ => tree
     }
@@ -66,11 +65,12 @@ object Checkable {
    */
   def checkable(X: Type, P: Type, pos: Position)(implicit ctx: Context): Boolean = {
     def isAbstract(P: Type) = !P.dealias.typeSymbol.isClass
+    def isPatternTypeSymbol(sym: Symbol) = !sym.isClass && sym.is(Case)
 
     def replaceP(implicit ctx: Context) = new TypeMap {
       def apply(tp: Type) = tp match {
         case tref: TypeRef
-        if !tref.typeSymbol.isClass && tref.symbol.is(Case) => WildcardType
+        if isPatternTypeSymbol(tref.typeSymbol) => WildcardType
         case AnnotatedType(_, annot)
         if annot.symbol == defn.UncheckedAnnot => WildcardType
         case _ => mapOver(tp)

tests/neg-custom-args/isInstanceOf/3324h.scala

@@ -0,0 +1,10 @@
+object Test {
+  trait Marker
+  def foo[T](x: T) = x match {
+    case _: (T & Marker)       => // no warning
+    // case _: T with Marker => // scalac emits a warning
+    case _ =>
+  }
+
+  def bar(x: Any) = x.isInstanceOf[List[String]]  // error
+}