Fix #3533: Fix parsing of raw types appearing in generic position

Only the ClassfileParser is fixed (because we can just ask users to fix
their Java source files to not use raw types to get them to compile with
Dotty). This means that the added Java testcase does not pass Dotty's
Java source parser, we handle this by putting "JAVA_ONLY" in the filename and
skipping files that contain this string from going through Dotty in our
testing framework.

Author: smarter

compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala

@@ -261,11 +261,11 @@ class ClassfileParser(
           addConstructorTypeParams(denot)
         }
 
-        denot.info = cook.apply(pool.getType(in.nextChar))
+        denot.info = pool.getType(in.nextChar)
         if (isEnum) denot.info = ConstantType(Constant(sym))
         if (isConstructor) normalizeConstructorParams()
         setPrivateWithin(denot, jflags)
-        denot.info = translateTempPoly(parseAttributes(sym, denot.info))
+        denot.info = translateTempPoly(cook.apply(parseAttributes(sym, denot.info)))
         if (isConstructor) normalizeConstructorInfo()
 
         if ((denot is Flags.Method) && (jflags & JAVA_ACC_VARARGS) != 0)

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -69,6 +69,7 @@ class CompilationTests extends ParallelTesting {
       ),
       scala2Mode
     ) +
+    compileFilesInDir("../tests/pos-special/i3273", defaultOptions) +
     compileFilesInDir("../tests/pos-special/spec-t5545", defaultOptions) +
     compileFilesInDir("../tests/pos-special/strawman-collections", defaultOptions) +
     compileFile("../scala2-library/src/library/scala/collection/immutable/IndexedSeq.scala", defaultOptions) +
@@ -109,7 +110,6 @@ class CompilationTests extends ParallelTesting {
     implicit val testGroup: TestGroup = TestGroup("posTwice")
     compileFile("../tests/pos/Labels.scala", defaultOptions) +
     compileFilesInDir("../tests/pos-java-interop", defaultOptions) +
-    compileFilesInDir("../tests/pos-java-interop-separate", defaultOptions) +
     compileFile("../tests/pos/t2168.scala", defaultOptions) +
     compileFile("../tests/pos/erasure.scala", defaultOptions) +
     compileFile("../tests/pos/Coder.scala", defaultOptions) +

compiler/test/dotty/tools/vulpix/ParallelTesting.scala

@@ -376,7 +376,10 @@ trait ParallelTesting extends RunnerOrchestration { self =>
 
       // Compile with a try to catch any StackTrace generated by the compiler:
       try {
-        driver.process(allArgs ++ files.map(_.getAbsolutePath), reporter = reporter)
+        // If a test contains a Java file that cannot be parsed by Dotty's Java source parser, its
+        // name must contain the string "JAVA_ONLY".
+        val dottyFiles = files.filterNot(_.getName.contains("JAVA_ONLY")).map(_.getAbsolutePath)
+        driver.process(allArgs ++ dottyFiles, reporter = reporter)
 
         val javaFiles = files.filter(_.getName.endsWith(".java")).map(_.getAbsolutePath)
         val javaErrors = compileWithJavac(javaFiles)

tests/pos-java-interop-separate/i3533/Test_2.scala

@@ -0,0 +1,3 @@
+object Test {
+  TryMe_JAVA_ONLY_1.ifYouCan(list => list.size())
+}

tests/pos-java-interop-separate/i3533/TryMe_JAVA_ONLY_1.java

@@ -0,0 +1,6 @@
+import java.util.function.Function;
+
+public class TryMe_JAVA_ONLY_1 {
+  public static void ifYouCan(Function<java.util.List, Integer> f) {
+  }
+}