Avoid duplicate hashCode/equals

Author: odersky

compiler/src/dotty/tools/dotc/core/Names.scala

@@ -105,6 +105,7 @@ object Names {
     def lastIndexOfSlice(str: String): Int = lastPart.toString.lastIndexOfSlice(str)
     def lastIndexOfSlice(name: Name): Int = lastIndexOfSlice(name.toString)
 
+    override def hashCode = System.identityHashCode(this)
     override def equals(that: Any) = this eq that.asInstanceOf[AnyRef]
   }
 
@@ -196,9 +197,6 @@ object Names {
       thisKind == kind ||
       !thisKind.definesNewName && thisKind.tag > kind.tag && underlying.is(kind)
     }
-
-    override def hashCode = System.identityHashCode(this)
-    override def equals(other: Any) = this eq other.asInstanceOf[AnyRef]
   }
 
   class SimpleTermName(val start: Int, val length: Int, @sharable private[Names] var next: SimpleTermName) extends TermName {

compiler/src/dotty/tools/dotc/core/tasty/TastyFormat.scala

@@ -222,8 +222,8 @@ object TastyFormat {
   final val UTF8 = 1
   final val QUALIFIED = 2
   final val FLATTENED = 3
-  final val EXPANDPREFIX = 5
   final val EXPANDED = 4
+  final val EXPANDPREFIX = 5
   final val TRAITSETTER = 6
   final val UNIQUE = 10
   final val DEFAULTGETTER = 11

compiler/src/dotty/tools/dotc/transform/TreeChecker.scala

@@ -403,7 +403,8 @@ class TreeChecker extends Phase with SymTransformer {
     override def typedDefDef(ddef: untpd.DefDef, sym: Symbol)(implicit ctx: Context) =
       withDefinedSyms(ddef.tparams) {
         withDefinedSymss(ddef.vparamss) {
-          if (!sym.isClassConstructor && !(sym.name eq Names.STATIC_CONSTRUCTOR)) assert(isValidJVMMethodName(sym.name), s"${sym.fullName} name is invalid on jvm")
+          if (!sym.isClassConstructor && !(sym.name eq Names.STATIC_CONSTRUCTOR))
+            assert(isValidJVMMethodName(sym.name), s"${sym.name.debugString} name is invalid on jvm")
 
           ddef.vparamss.foreach(_.foreach { vparam =>
             assert(vparam.symbol.is(Param),