Generalize Name.likeSpaced and hide the one from NameDecorator

Author: Blaisorblade

compiler/src/dotty/tools/dotc/core/NameOps.scala

@@ -58,8 +58,8 @@ object NameOps {
       case _ => false
     }
 
-    def likeSpaced(n: PreName): N =
-      (if (name.isTermName) n.toTermName else n.toTypeName).asInstanceOf[N]
+    private def likeSpaced(n: PreName): N =
+      name.likeSpaced(n).asInstanceOf[N]
 
     def isConstructorName = name == CONSTRUCTOR || name == TRAIT_CONSTRUCTOR
     def isStaticConstructorName = name == STATIC_CONSTRUCTOR

compiler/src/dotty/tools/dotc/core/Names.scala

@@ -98,7 +98,7 @@ object Names {
     /** A name in the same (term or type) namespace as this name and
      *  with same characters as given `name`.
      */
-    def likeSpaced(name: Name): ThisName
+    def likeSpaced(name: PreName): ThisName
 
     /** A derived name consisting of this name and the added info, unless it is
      *  already present in this name.
@@ -181,7 +181,7 @@ object Names {
       _typeName
     }
 
-    override def likeSpaced(name: Name): TermName = name.toTermName
+    override def likeSpaced(name: PreName): TermName = name.toTermName
 
     def info: NameInfo = SimpleNameKind.info
     def underlying: TermName = unsupported("underlying")
@@ -450,7 +450,7 @@ object Names {
     override def mapLast(f: SimpleName => SimpleName) = toTermName.mapLast(f).toTypeName
     override def mapParts(f: SimpleName => SimpleName) = toTermName.mapParts(f).toTypeName
 
-    override def likeSpaced(name: Name): TypeName = name.toTypeName
+    override def likeSpaced(name: PreName): TypeName = name.toTypeName
 
     override def derived(info: NameInfo): TypeName = toTermName.derived(info).toTypeName
     override def exclude(kind: NameKind): TypeName = toTermName.exclude(kind).toTypeName