Merge pull request #143 from scala/backport-lts-3.3-21865

Backport "Do not bring forward symbols created in transform and backend phases" to 3.3 LTS

Author: tgodzik

compiler/src/dotty/tools/dotc/core/Denotations.scala

@@ -736,6 +736,8 @@ object Denotations {
      *     the old version otherwise.
      *   - If the symbol did not have a denotation that was defined at the current phase
      *     return a NoDenotation instead.
+     *   - If the symbol was first defined in one of the transform phases (after pickling), it should not
+     *     be visible in new runs, so also return a NoDenotation.
      */
     private def bringForward()(using Context): SingleDenotation = {
       this match {
@@ -749,6 +751,7 @@ object Denotations {
       }
       if (!symbol.exists) return updateValidity()
       if (!coveredInterval.containsPhaseId(ctx.phaseId)) return NoDenotation
+      if (coveredInterval.firstPhaseId >= Phases.firstTransformPhase.id) return NoDenotation
       if (ctx.debug) traceInvalid(this)
       staleSymbolError
     }

tests/pos-macros/i21844/Macro.scala

@@ -0,0 +1,6 @@
+import scala.quoted.*
+
+object Macro:
+  inline def foo = ${ fooImpl }
+  def fooImpl(using Quotes): Expr[Int] =
+    '{ 123 }

tests/pos-macros/i21844/SubClass.scala

@@ -0,0 +1,3 @@
+class SubClass extends SuperClass
+object SubClass:
+  val foo: Int = Macro.foo

tests/pos-macros/i21844/SuperClassWithLazyVal.scala

@@ -0,0 +1,2 @@
+class SuperClass:
+  lazy val xyz: Int = 123