Merge pull request #416 from scala/backport-lts-3.3-23143

Backport "Disallow empty parameter clauses in `extension` definition" to 3.3 LTS

Author: tgodzik

compiler/src/dotty/tools/dotc/parsing/Parsers.scala

@@ -3412,7 +3412,10 @@ object Parsers {
       // begin termParamClause
       inParensWithCommas {
         if in.token == RPAREN && paramOwner != ParamOwner.ExtensionPrefix && !impliedMods.is(Given)
-        then Nil
+        then
+          if paramOwner.takesOnlyUsingClauses then
+            syntaxError(em"`using` expected")
+          Nil
         else
           val clause =
             if paramOwner == ParamOwner.ExtensionPrefix
@@ -4060,7 +4063,10 @@ object Parsers {
         leadParamss += extParams
         isUsingClause(extParams)
       do ()
-      leadParamss ++= termParamClauses(ParamOwner.ExtensionFollow, numLeadParams)
+      // Empty parameter clauses are filtered out. They are already reported as syntax errors and are not
+      // allowed here.
+      val extFollowParams = termParamClauses(ParamOwner.ExtensionFollow, numLeadParams).filterNot(_.isEmpty)
+      leadParamss ++= extFollowParams
       if in.isColon then
         syntaxError(em"no `:` expected here")
         in.nextToken()

tests/neg/extensions-can-only-have-using.scala

@@ -0,0 +1,3 @@
+extension(x: Any)() // error
+  def f = 42
+val x = Nil.f