From 3f9da0fffd700003549a8a43a917d458c373a43c Mon Sep 17 00:00:00 2001 From: cgewecke Date: Fri, 5 Apr 2024 15:41:39 -0700 Subject: [PATCH 1/4] Document extendConfig changes in README --- README.md | 7 +++++++ test/sources/projects/viem/test/lock.js | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index b820bbf0..2f3f920a 100644 --- a/README.md +++ b/README.md @@ -56,6 +56,13 @@ $ npx hardhat compile $ TS_NODE_TRANSPILE_ONLY=true npx hardhat coverage ``` +**Weird test failures or plugin conflicts?** +``sh +# Setting the SOLIDITY_COVERAGE env variable tells the coverage plugin to configure the provider +# early in the hardhat `task` cycle, minimizing conflicts with other plugins or `extendEnvironment` hooks +$ SOLIDITY_COVERAGE=true npx hardhat coverage +`` + **Additional Help** + [FAQ][1007] + [Advanced Topics][1005] diff --git a/test/sources/projects/viem/test/lock.js b/test/sources/projects/viem/test/lock.js index 5ae4f650..255899d8 100644 --- a/test/sources/projects/viem/test/lock.js +++ b/test/sources/projects/viem/test/lock.js @@ -117,7 +117,7 @@ describe("Lock", function () { }); }); - describe.skip("Events", function () { + describe("Events", function () { it("Should emit an event on withdrawals", async function () { const { lock, unlockTime, lockedAmount, publicClient } = await loadFixture(deployOneYearLockFixture); From 91ca39c70f3ad82dce50a2e2876d5a3edfee74f9 Mon Sep 17 00:00:00 2001 From: cgewecke Date: Fri, 5 Apr 2024 15:42:57 -0700 Subject: [PATCH 2/4] Fix readme --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 2f3f920a..2466b288 100644 --- a/README.md +++ b/README.md @@ -57,11 +57,11 @@ $ TS_NODE_TRANSPILE_ONLY=true npx hardhat coverage ``` **Weird test failures or plugin conflicts?** -``sh +```sh # Setting the SOLIDITY_COVERAGE env variable tells the coverage plugin to configure the provider # early in the hardhat `task` cycle, minimizing conflicts with other plugins or `extendEnvironment` hooks $ SOLIDITY_COVERAGE=true npx hardhat coverage -`` +``` **Additional Help** + [FAQ][1007] From 033e0a13c7c25c58501b3490973a4f783d58c31c Mon Sep 17 00:00:00 2001 From: cgewecke Date: Fri, 5 Apr 2024 15:44:49 -0700 Subject: [PATCH 3/4] more readme changes --- README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 2466b288..b759de16 100644 --- a/README.md +++ b/README.md @@ -57,9 +57,10 @@ $ TS_NODE_TRANSPILE_ONLY=true npx hardhat coverage ``` **Weird test failures or plugin conflicts?** + +Setting the `SOLIDITY_COVERAGE` env variable tells the coverage plugin to configure the provider +early in the hardhat task cycle, minimizing conflicts with other plugins or `extendEnvironment` hooks ```sh -# Setting the SOLIDITY_COVERAGE env variable tells the coverage plugin to configure the provider -# early in the hardhat `task` cycle, minimizing conflicts with other plugins or `extendEnvironment` hooks $ SOLIDITY_COVERAGE=true npx hardhat coverage ``` From fb2eb0c36a777a6e1a8d8740cf5b345de25158bf Mon Sep 17 00:00:00 2001 From: cgewecke Date: Fri, 5 Apr 2024 15:46:17 -0700 Subject: [PATCH 4/4] readme..... --- README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b759de16..a658f45d 100644 --- a/README.md +++ b/README.md @@ -58,9 +58,10 @@ $ TS_NODE_TRANSPILE_ONLY=true npx hardhat coverage **Weird test failures or plugin conflicts?** -Setting the `SOLIDITY_COVERAGE` env variable tells the coverage plugin to configure the provider -early in the hardhat task cycle, minimizing conflicts with other plugins or `extendEnvironment` hooks ```sh +# Setting the `SOLIDITY_COVERAGE` env variable tells the coverage plugin to configure the provider +# early in the hardhat task cycle, minimizing conflicts with other plugins or `extendEnvironment` hooks + $ SOLIDITY_COVERAGE=true npx hardhat coverage ```