Skip to content

Conversation

@cgewecke
Copy link
Member

@cgewecke cgewecke commented Jan 6, 2021

Fixes a bug found running Synthetix where modifiers are invoked twice in the same function header, e.g

    function exchangeEtherForSNX()
        external
        payable
        rateNotInvalid(SNX)
        rateNotInvalid(ETH)
        notPaused
        returns (
            uint // Returns the number of SNX received
        )
    {
        return _exchangeEtherForSNX();
    }

PR disambiguates these using a counter.

@cgewecke cgewecke merged commit b348134 into experimental-options Jan 6, 2021
@cgewecke cgewecke deleted the fix-duplicate-modifiers branch January 6, 2021 01:01
@cgewecke cgewecke mentioned this pull request Jan 6, 2021
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants