Skip to content

Conversation

@cgewecke
Copy link
Member

@cgewecke cgewecke commented Dec 2, 2019

Resolves #429

There's a bug in earlier versions of Truffle where running the compilation and tests steps separately when a file had no contract definition resulted in an additional compilation on test which crashed.

Truffle Version Result
5.0.31 fail
5.0.38 fail
5.1.2 success

Have updated test for this case and upgraded T.

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #454 into beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta     #454   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          20       20           
  Lines         779      779           
=======================================
  Hits          773      773           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 212c88f...faa6cb2. Read the comment docs.

@cgewecke cgewecke merged commit 1ea44ea into beta Dec 3, 2019
@cgewecke cgewecke deleted the bug/import-only branch December 3, 2019 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants