Skip to content

Stop camel-casing testfiles flag #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Stop camel-casing testfiles flag #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ npx buidler coverage [command-options]
| Option <img width=200/> | Example <img width=750/>| Description <img width=1000/> |
|--------------|------------------------------------|--------------------------------|
| file | `--file="test/registry/*.js"` | (Truffle) Filename or glob describing a subset of JS tests to run. (Globs must be enclosed by quotes.)|
| testFiles | `--testFiles test/file.js` | (Buidler) JS test file(s) to run.|
| testfiles | `--testfiles test/file.js` | (Buidler) JS test file(s) to run.|
| solcoverjs | `--solcoverjs ./../.solcover.js` | Relative path from working directory to config. Useful for monorepo packages that share settings. (Path must be "./" prefixed) |
| network | `--network development` | Use network settings defined in the Truffle or Buidler config |
| temp[<sup>*</sup>][14] | `--temp build` | :warning: **Caution** :warning: Path to a *disposable* folder to store compilation artifacts in. Useful when your test setup scripts include hard-coded paths to a build directory. [More...][14] |
Expand Down
6 changes: 3 additions & 3 deletions dist/buidler.plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function plugin() {

task("coverage", "Generates a code coverage report for tests")

.addOptionalParam("testFiles", ui.flags.file, null, types.string)
.addOptionalParam("testfiles", ui.flags.file, null, types.string)
.addOptionalParam("solcoverjs", ui.flags.solcoverjs, null, types.string)
.addOptionalParam('temp', ui.flags.temp, null, types.string)

Expand Down Expand Up @@ -112,10 +112,10 @@ function plugin() {
// ======
// Tests
// ======
const testFiles = args.testFiles ? [args.testFiles] : [];
const testfiles = args.testfiles ? [args.testfiles] : [];

try {
await env.run(TASK_TEST, {testFiles: testFiles})
await env.run(TASK_TEST, {testFiles: testfiles})
} catch (e) {
error = e;
}
Expand Down
4 changes: 2 additions & 2 deletions test/units/buidler/flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ describe('Buidler Plugin: command line options', function() {
verify.lineCoverage(expected);
});

it('--testFiles test/<fileName>', async function() {
it.only('--testfiles test/<fileName>', async function() {
const taskArgs = {
testFiles: path.join(
testfiles: path.join(
buidlerConfig.paths.root,
'test/specific_a.js'
)
Expand Down