[Backport] Remove parameter from method calling #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…15233 - Merge Pull Request magento#15233 from VitaliyBoyko/magento2:fix/design-rule-typo - Merged commits: 1. 9994410
…o#15234 - Merge Pull Request magento#15234 from VitaliyBoyko/magento2:11440-Add-missing-translations-in-Magento_UI - Merged commits: 1. 0c2e496
- Merge Pull Request magento#15235 from VitaliyBoyko/magento2:11569-Fixed_double_space_typo - Merged commits: 1. d41e2c5
…nfig is used magento#15238 - Merge Pull Request magento#15238 from VitaliyBoyko/magento2:Fixed-php-notice-when-invalid-ui_component-config-is-used - Merged commits: 1. 5980670
…agento#15237 - Merge Pull Request magento#15237 from VitaliyBoyko/magento2:Changed-constructor-typo-in-Javascript-class - Merged commits: 1. 76c4463
Accepted Public Pull Requests: - magento#15237: [Backport] Changed constructor typo in Javascript class (by @VitaliyBoyko) - magento#15235: [Backport] Fixed double space typo (by @VitaliyBoyko)
Accepted Public Pull Requests: - magento#15238: [Backport] Fixed php notice when invalid ui_component config is used (by @VitaliyBoyko) - magento#15234: [Backport] Add missing translations in Magento_UI (by @VitaliyBoyko) - magento#15233: [Backport] Fix typo in design rule hint message (by @VitaliyBoyko)
…tered in email_invoice_set_template_vars_before Event magento#15038
Accepted Public Pull Requests: - magento#15038: [2.1-develop][Backport] Transport variable can not be altered in email_invoice_set_template_vars_before Event (by @gwharton) Fixed GitHub Issues: - magento#10210: Transport variable can not be altered in email_invoice_set_template_vars_before Event (reported by @diybook) has been fixed in magento#15038 by @gwharton in 2.1-develop branch Related commits: 1. 9a95dae
Fixed issues: - MAGETWO-91894 Backport Static Test Fixes in CE
- Merge Pull Request magento#15866 from dmytro-ch/magento2:2.1-develop-PR-port-15845 - Merged commits: 1. 228b765
…riables in Luma theme… magento#15796
Accepted Public Pull Requests: - magento#15767: [Backport] FIX fo rissue magento#15510 - First PDF download / export after login (by @sanjay-wagento) - magento#15797: [Backport] Removed unnecessary css. #3 (by @chirag-wagento) - magento#15796: [Backport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento) - magento#15801: [Backport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @viral-wagento) - magento#15855: [Backport 2.1] Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar) - magento#15841: [Backport] Fix for issue 911 found on MSI project - Cannot read property source_� magento#15 (by @chirag-wagento) - magento#15776: [Backport] Added additional headers for avoiding customer data caching (by @rogyar) Fixed GitHub Issues: - magento#15510: First PDF download / export after login (reported by @anthony-jullien) has been fixed in magento#15767 by @sanjay-wagento in 2.1-develop branch Related commits: 1. 8e43c07 - magento#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento#15796 by @hitesh-wagento in 2.1-develop branch Related commits: 1. d3184ac
…les magento#15887 - Merge Pull Request magento#15887 from rahul-kachhadiya/magento2:2.1-develop-PR-port-15371 - Merged commits: 1. 6ab1020
- Merge Pull Request magento#15920 from DanielRuf/magento2:2.1-develop-PR-port-15871 - Merged commits: 1. fc35b01
…s list magento#15924 - Merge Pull Request magento#15924 from dmytro-ch/magento2:2.1-develop-PR-port-14473 - Merged commits: 1. 6c6d67f
- Merge Pull Request magento#15925 from dmytro-ch/magento2:2.1-develop-PR-port-14358 - Merged commits: 1. 6027744
…15926 - Merge Pull Request magento#15926 from dmytro-ch/magento2:2.1-develop-PR-port-14350 - Merged commits: 1. 6257807
…ento#15927 - Merge Pull Request magento#15927 from dmytro-ch/magento2:2.1-develop-PR-port-14306 - Merged commits: 1. 0658873
Accepted Public Pull Requests: - magento#15927: [Backport] [magento#14089] Add Malaysian Locale Code (by @dmytro-ch) - magento#15926: [Backport] precision for price overriding by js (by @dmytro-ch) - magento#15925: [Backport] Format code (by @dmytro-ch) - magento#15924: [Backport] Added spanish Bolivia locale to allowedLocales list (by @dmytro-ch) - magento#15920: [Backport] chore: remove unused less import (by @DanielRuf) - magento#15887: [Backport-2.1] Added language translation in template files (by @rahul-kachhadiya) - magento#15866: [Backport] Update webapi.xml to fix typo (by @dmytro-ch) - magento#15290: [Backport] Fix typo in database column comment (by @VitaliyBoyko) Fixed GitHub Issues: - magento#14089: Malaysian (Malaysia) missing from locale list (reported by @superdav42) has been fixed in magento#15927 by @dmytro-ch in 2.1-develop branch Related commits: 1. 0658873 - magento#14249: Priduct page price is using the hardcoded digits in js (reported by @cdiacon) has been fixed in magento#15926 by @dmytro-ch in 2.1-develop branch Related commits: 1. 6257807
saurabh-parekh
pushed a commit
that referenced
this pull request
Jun 8, 2018
[Forwardport] Added language translation for comment tag
saurabh-parekh
pushed a commit
that referenced
this pull request
Jun 11, 2018
Updated Branch 2.2-develop from Magento 2 upstream
saurabh-parekh
pushed a commit
that referenced
this pull request
Jun 11, 2018
…ata\SearchResultProcessor.php #2
saurabh-parekh
pushed a commit
that referenced
this pull request
Jun 19, 2018
…ata\SearchResultProcessor.php #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15891
Remove parameter from method calling
Description
Method definition does not require any parameters. But when it was actually called extra parameter was passed. I remove extra parameter while calling method.
Fixed Issues (if relevant)
N/A
Manual testing scenarios
1 You can check at magento admin panel -> Marketing -> SEO & Search -> URL Rewrites -> Add/Edit with product.
Contribution checklist