Skip to content

Commit fcf11a6

Browse files
RavkiDottenpixel
andauthored
fix(accordion): sass undefined operation compile error (#5040)
* fix(accordion): sass undefined operation compile error * fix(accordion): fix accordion margin rules * chore(accordion): add release notes * fix(accordion): release version change Co-authored-by: DouG Molidor <[email protected]>
1 parent 13182f7 commit fcf11a6

File tree

3 files changed

+22
-8
lines changed

3 files changed

+22
-8
lines changed

RELEASENOTES.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,13 @@
1818
- Added `video_off`
1919

2020
## Components
21+
22+
### [Accordion](https://www.lightningdesignsystem.com/components/accordion)
23+
#### Fixed
24+
25+
- Fix for sass undefined operation compile error.
26+
- Fix wrong computed css margin rules.
27+
2128
### [Button Icons](https://www.lightningdesignsystem.com/components/button-icons)
2229
#### Added
2330
- Added `slds-button_icon-large` to support a Large variant for contained button icons

ui/components/accordion/RELEASENOTES.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.18.0
8+
9+
### Fixed
10+
11+
- Fix for sass undefined operation compile error.
12+
- Fix wrong computed css margin rules.
13+
714
## 2.17.0
815

916
### Added

ui/components/accordion/base/_index.scss

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,19 @@
3939
margin-top: calc(
4040
var(--slds-c-accordion-section-spacing-block-start,
4141
var(--sds-c-accordion-section-spacing-block-start,
42-
#{$spacing-small} * -1)));
42+
#{$spacing-small})) * -1);
4343
margin-right: calc(
4444
var(--slds-c-accordion-section-spacing-inline-end,
4545
var(--sds-c-accordion-section-spacing-inline-end,
46-
#{$spacing-small} * -1)));
46+
#{$spacing-small})) * -1);
4747
margin-bottom: calc(
4848
var(--slds-c-accordion-section-spacing-block-end,
4949
var(--sds-c-accordion-section-spacing-block-end,
50-
#{$spacing-small} * -1)));
50+
#{$spacing-small})) * -1);
5151
margin-left: calc(
5252
var(--slds-c-accordion-section-spacing-inline-start,
5353
var(--sds-c-accordion-section-spacing-inline-start,
54-
#{$spacing-small} * -1)));
54+
#{$spacing-small})) * -1);
5555
padding-top: var(--slds-c-accordion-section-spacing-block-start, var(--sds-c-accordion-section-spacing-block-start, #{$spacing-small}));
5656
padding-right: var(--slds-c-accordion-section-spacing-inline-end, var(--sds-c-accordion-section-spacing-inline-end, #{$spacing-small}));
5757
padding-bottom: var(--slds-c-accordion-section-spacing-block-end, var(--sds-c-accordion-section-spacing-block-end, #{$spacing-small}));
@@ -91,19 +91,19 @@
9191
margin-top: calc(
9292
var(--slds-c-accordion-section-spacing-block-start,
9393
var(--sds-c-accordion-section-spacing-block-start,
94-
#{$spacing-small} * -1)));
94+
#{$spacing-small})) * -1);
9595
margin-right: calc(
9696
var(--slds-c-accordion-section-spacing-inline-end,
9797
var(--sds-c-accordion-section-spacing-inline-end,
98-
#{$spacing-small} * -1)));
98+
#{$spacing-small})) * -1);
9999
margin-bottom: calc(
100100
var(--slds-c-accordion-section-spacing-block-end,
101101
var(--sds-c-accordion-section-spacing-block-end,
102-
#{$spacing-small} * -1)));
102+
#{$spacing-small})) * -1);
103103
margin-left: calc(
104104
var(--slds-c-accordion-section-spacing-inline-start,
105105
var(--sds-c-accordion-section-spacing-inline-start,
106-
#{$spacing-small} * -1)));
106+
#{$spacing-small})) * -1);
107107
padding-top: var(--slds-c-accordion-section-spacing-block-start, var(--sds-c-accordion-section-spacing-block-start, $spacing-small));
108108
padding-right: var(--slds-c-accordion-section-spacing-inline-end, var(--sds-c-accordion-section-spacing-inline-end, $spacing-small));
109109
padding-bottom: var(--slds-c-accordion-section-spacing-block-end, var(--sds-c-accordion-section-spacing-block-end, $spacing-small));

0 commit comments

Comments
 (0)