Skip to content

[patchmanager.cpp] Fix-up release 3.2.10 ⇒ 3.2.11 #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2023
Merged

[patchmanager.cpp] Fix-up release 3.2.10 ⇒ 3.2.11 #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b93fd0c
[patchmanager.cpp] Fix-up release 3.2.10
Olf0 Aug 14, 2023
db2e8f8
Fix syntax / copypaste error
Aug 14, 2023
ba6b989
Remove empty/stub methods.
Aug 14, 2023
054a5bc
[patchmanager.h] Mark two definitions as "apparently unused":
Olf0 Aug 15, 2023
e12eef3
[patchmanager.h] Remove `Apparently unused!` comments
Olf0 Aug 15, 2023
5027c08
[patchmanager.spec] Pre-release version increase
Olf0 Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rpm/patchmanager.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
Name: patchmanager

Summary: Allows to manage Patches for SailfishOS
Version: 3.2.10
Version: 3.2.11
Release: 1
# The Group tag should comprise one of the groups listed here:
# https://github.com/mer-tools/spectacle/blob/master/data/GROUPS
Expand Down
16 changes: 0 additions & 16 deletions src/qml/patchmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,22 +1013,6 @@ bool PatchManagerTranslator::installTranslator(const QString &patch)
return true;
}

/*! void PatchManager::activation(const QString & patch, const QString & version);
\warning probably dead code, need to investigate
probably \internal, using \a patch and \a version
*/
void PatchManager::activation(const QString & patch, const QString & version)
{
}

/*! void PatchManager::easterReceived(const QString & easterText);
\warning probably dead code, need to investigate
probably \internal, using \a easterText
*/
void PatchManager::easterReceived(const QString & easterText);
{
}

/*!
Returns \e true if \a filename exists, \e false otherwise.
\sa https://doc.qt.io/qt-5/qfile.html#exists-1
Expand Down
2 changes: 1 addition & 1 deletion src/qml/patchmanager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class PatchManagerVersionCheck
enum CheckMode {
Strict,
NoCheck,
//Relaxed, // TODO, Issue #322, also see https://github.com/sailfishos-patches/patchmanager/issues/333#issuecomment-1374118045
//Relaxed, // TODO, see issue #322, also see https://github.com/sailfishos-patches/patchmanager/issues/333#issuecomment-1374118045
};
Q_ENUM(CheckMode)
private:
Expand Down