Skip to content

Conversation

@Olf0
Copy link
Contributor

@Olf0 Olf0 commented Dec 30, 2021

This still ought be functionally equivalent to the original version as of PM 3.2.0: please test!

This still ought be functionally equivalent to the original version as of PM 3.2.0: please test!
@Olf0 Olf0 requested a review from nephros December 30, 2021 05:41
Olf0 added a commit that referenced this pull request Dec 30, 2021
This is on top of MR #221, so each step can be well tested, separately
@Olf0
Copy link
Contributor Author

Olf0 commented Dec 30, 2021

Please test this first (merged into master or not), before dealing with MR #222.

@Olf0
Copy link
Contributor Author

Olf0 commented Dec 30, 2021

Please review, then squash-merge and test.

Copy link
Contributor

@nephros nephros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from eyeball review. Didn't test yet, will do together with the other one.

Thank you!

@nephros nephros merged commit 028c3c9 into master Jan 3, 2022
@nephros nephros deleted the Olf0-patch-1 branch January 3, 2022 17:47
@Olf0 Olf0 changed the title Prepare for multiple conversion runs [pm_apply] Prepare for multiple conversion runs Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants