New Gap spkg (>=4.5) does not build with shared only GMP/MPIR

[jpflori]

And we only build a shared one on Cygwin because we cannot build both static and shared (although this limitation is not clearly still needed).

Try spkg at
http://boxen.math.washington.edu/home/jpflori/gap-4.5.7.p3.spkg

CC: @kcrisman @dimpase

Component: packages: standard

Keywords: spkg gap cygwin

Author: Jean-Pierre Flori

Reviewer: Dmitrii Pasechnik

Merged: sage-5.7.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13954

[jpflori]

comment:1

The configure script tests for libgmp.a if --with-gmp=... is passed.

[kcrisman]

comment:2

Would this explain my current problem that GAP doesn't build on XP? Configure fails with

configure: error: Could not locate GMP in the specified location

[jpflori]

comment:3

Yes that's it.

[jpflori]

comment:4

Ok, I got GAP to build but the script gap_cygwin is completely broken as well.

[jpflori]

comment:5

Ok we basically have to remove all Cygwin specific things from spkg-install.

[kcrisman]

comment:6

Great, provide something and I can still try it today!

Nice that the folks at #13211 managed to do this

if [ "x$GAP_DIR" = "x" ];  then
    GAP_DIR="$SAGE_ROOT/local/lib/gap-4.5.5" 
fi

but then somehow not update it to 4.5.7!?

[kcrisman]

comment:7

By the way, WHY do we need to start GAP to start Sage? I know that sage-location or some similar script does this upon the first start... but it does seem a bit much.

[jpflori]

comment:8

Anyway even the SAGE_ROOT part is wrong.

Try a dirty spkg at http://boxen.math.washington.edu/home/jpflori/gap-4.5.7.p2.spkg

[vbraun]

comment:9

Looks good to me.

Not sure what you mean by needing to start GAP for Sage. Sage startup doesn't start a GAP session. The GAP workspace cache needs to be rebuilt once, though.

[kcrisman]

comment:10

diff --git a/spkg-install b/spkg-install
--- a/spkg-install
+++ b/spkg-install
@@ -86,34 +86,6 @@
     exit 1
 fi
 
-# On Cygwin installations the GAP build creates a file 'gap.exe',
-# and then tries to strip the file 'gap'.
-# This broke the build on old Cygwin installations.
-# On newer Cygwins, 'gap' is automatically "translated" to 'gap.exe'.
-if [[ "$UNAME" = CYGWIN ]]; then
-    echo "Creating a dummy 'gap.exe' in 'bin/i686-pc-cygwin-gcc'..."
-    cd "$SPKG_ROOT/src"
-    mkdir -p bin/i686-pc-cygwin-gcc &&
-    cd bin/i686-pc-cygwin-gcc &&
-    touch gap.exe
-    if [[ $? -ne 0 ]]; then
-        # Something really went wrong.
-        echo >&2 "Error creating a dummy gap.exe file."
-        exit 1
-    fi
-    # Check if 'gap' is automatically "translated" to 'gap.exe'.
-    # If not, create a symbolic link from 'gap' to 'gap.exe'.
-    if [[ ! -f gap ]]; then
-        echo "Creating a symbolic link from 'gap' to 'gap.exe'..."
-        ln -s gap.exe gap
-        if [[ $? -ne 0 ]]; then
-            # Something really went wrong.
-            echo >&2 "Error creating the symbolic link."
-            exit 1
-        fi
-    fi
-fi
-
 echo "Building GAP..."
 cd "$SPKG_ROOT/src"
 $MAKE -j1
@@ -144,11 +116,7 @@
 echo "Copying GAP startup script..."
 rm -f "$SAGE_LOCAL/bin/gap"
 cd "$SPKG_ROOT"
-if [[ "$UNAME" = CYGWIN ]]; then
-    cp patches/gap_cygwin "$SAGE_LOCAL/bin/gap"
-else
-    cp src/bin/gap.sh "$SAGE_LOCAL/bin/gap"
-fi
+cp src/bin/gap.sh "$SAGE_LOCAL/bin/gap"
 if [[ $? -ne 0 ]]; then
     echo >&2 "Error copying customized GAP startup script."
     exit 1

Yeah, if it works, then we are set. It just finished building for me... sage -b now... that worked... Trying to start, sage-location is being run... it works!!!

Commit and make the spkg, this is ready to go.

Not sure what you mean by needing to start GAP for Sage. Sage startup doesn't start a GAP session. The GAP workspace cache needs to be rebuilt once, though.

Well, there is a GAP command that is run (and fails here, gap -r -b -p -T -o 251m .../gap/sage.g), so that sounds like GAP to me. Also, upon a first start (or relocation), Sage always says something about stopping a GAP session. But if it's not technically a session, that's fine; my point was that it does something, which e.g. Singular and Maxima don't.