uefi: Drop 'boot lifetime from Output protocol
#689
Merged
+25
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Output` protocol has an internal pointer to an `OutputData` object. This was represented as a reference with the `'boot` lifetime, but this isn't quite right since the actual lifetime could be shorter than boot services. Furthermore, in several places the lifetime parameter was set to `'static`, which is definitely not correct. Fix by dropping the lifetime parameter, and instead just use a raw pointer. This is more in line with how we've implemented other protocols.
nicholasbishop
force-pushed
the
output-drop-lifetime
branch
from
878e6e1 to
48e8f25
Compare
phip1611
approved these changes
Mar 12, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Outputprotocol has an internal pointer to anOutputDataobject. This was represented as a reference with the'bootlifetime, but this isn't quite right since the actual lifetime could be shorter than boot services. Furthermore, in several places the lifetime was set to'static, which is definitely not correct.Fix by dropping the lifetime parameter, and instead just use a raw pointer. This is more in line with how we've implemented other protocols.
Checklist