cleanup

Author: hashemix

src/fs_service.rs

@@ -409,9 +409,8 @@ impl FileSystemService {
     /// # Arguments
     /// * `root_path` - The root directory to start the search from.
     /// * `pattern` - A glob pattern to match file names (case-insensitive). If no wildcards are provided,
-    ///               the pattern is wrapped in `*` for partial matching.
-    /// * `exclude_patterns` - A list of glob patterns to exclude paths (case-sensitive). If a pattern
-    ///                        lacks wildcards, it is wrapped in `*` for partial matching.
+    ///   the pattern is wrapped in '*' for partial matching.
+    /// * `exclude_patterns` - A list of glob patterns to exclude paths (case-sensitive).
     ///
     /// # Returns
     /// A `ServiceResult` containing a vector of`walkdir::DirEntry` objects for matching files,
@@ -431,10 +430,8 @@ impl FileSystemService {
     ///
     /// # Arguments
     /// * `root_path` - The root directory to start the search from.
-    /// * `pattern` - A glob pattern to match file names. If no wildcards are provided,
-    ///               the pattern is wrapped in `**/*{pattern}*` for partial matching.
-    /// * `exclude_patterns` - A list of glob patterns to exclude paths (case-sensitive). If a pattern
-    ///                        lacks wildcards, it is wrapped in `*` for partial matching.
+    /// * `pattern` - A glob pattern to match file names. If no wildcards are provided, the pattern is wrapped in `**/*{pattern}*` for partial matching.
+    /// * `exclude_patterns` - A list of glob patterns to exclude paths (case-sensitive).
     ///
     /// # Returns
     /// A `ServiceResult` containing an iterator yielding `walkdir::DirEntry` objects for matching files,
@@ -767,9 +764,9 @@ impl FileSystemService {
     /// before the start position of the `match`, and extends up to `max_length` characters
     /// If the snippet does not include the beginning or end of the original line, ellipses (`"..."`) are added
     /// to indicate the truncation.
-    pub fn extract_snippet<'a>(
+    pub fn extract_snippet(
         &self,
-        line: &'a str,
+        line: &str,
         match_result: Match,
         max_length: Option<usize>,
         backward_chars: Option<usize>,
@@ -812,12 +809,12 @@ impl FileSystemService {
         let files_iter = self.search_files_iter(
             root_path.as_ref(),
             pattern.to_string(),
-            exclude_patterns.to_owned().unwrap_or(vec![]),
+            exclude_patterns.to_owned().unwrap_or_default(),
         )?;
 
         let results: Vec<FileSearchResult> = files_iter
             .filter_map(|entry| {
-                self.content_search(&query, entry.path(), Some(is_regex))
+                self.content_search(query, entry.path(), Some(is_regex))
                     .ok()
                     .and_then(|v| v)
             })

src/tools/search_files_content.rs

@@ -76,14 +76,12 @@ impl SearchFilesContentTool {
                         ServiceError::FromString("No matches found in the files content.".into()),
                     )));
                 }
-                return Ok(CallToolResult::text_content(
+                Ok(CallToolResult::text_content(
                     params.format_result(results),
                     None,
-                ));
+                ))
             }
-            Err(err) => {
-                return Ok(CallToolResult::with_error(CallToolError::new(err)));
-            }
-        };
+            Err(err) => Ok(CallToolResult::with_error(CallToolError::new(err))),
+        }
     }
 }

tests/test_fs_service.rs

@@ -999,7 +999,7 @@ async fn test_snippet_back_chars() {
     // larger text, truncates at the end
     let line = "this is a long enough line for testing match in middles .";
     let m = Match::new(40, 45);
-    let result = service.extract_snippet(&line, m, Some(20), Some(5));
+    let result = service.extract_snippet(line, m, Some(20), Some(5));
     assert!(result.starts_with("..."));
     assert!(result.ends_with("..."));
     assert!(result.contains("match"));
@@ -1081,13 +1081,13 @@ fn search_files_content() {
     );
 
     fs::copy("/Users/ahashemi/Ali/proj/rust-mcp-stack/rust-mcp-filesystem/target/debug/librust_mcp_filesystem.d",
-        &temp_dir.as_path().join("dir_search").join("xyz.txt")).unwrap();
+        temp_dir.as_path().join("dir_search").join("xyz.txt")).unwrap();
 
     let query = r#"Watso\d*n"#;
 
     let results = service
         .search_files_content(
-            &temp_dir.as_path().join("dir_search"),
+            temp_dir.as_path().join("dir_search"),
             "*.txt",
             query,
             true,