Add Karrq's salsa chapter #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also, it appears the backing branch was deleted or something in the other PR? |
Contributor
Author
|
cc @spastorino who approved the original |
|
Yes I'm sorry I was planning to reply to the issue but alas I got stormed with other things. I wanted to let you know that I couldn't work on this anymore... Sorry. And yes I deleted the fork accidentally. Github doesn't really warn you about open pull requests when you do that... |
spastorino
approved these changes
Nov 27, 2019
mark-i-m
added a commit
to spastorino/rustc-dev-guide
that referenced
this pull request
Jan 2, 2020
* add Karrq's salsa chapter * add youtu.be short url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #401
cc @Karrq (who gets all credit for this content)
This great content, but Karrq doesn't seem to have time ATM and the PR has been open for too long.