From c299230f3d7a43a4307ce317aa41b7e8f361a2e6 Mon Sep 17 00:00:00 2001 From: Corey Richardson Date: Sat, 1 Jun 2013 00:55:19 -0400 Subject: [PATCH] Optimize vec::from_elem with manual inlining (borrowck 1.85x speedup on libstd) --- src/libstd/vec.rs | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/libstd/vec.rs b/src/libstd/vec.rs index 795c3cdb405e1..8eedb70b3a6f4 100644 --- a/src/libstd/vec.rs +++ b/src/libstd/vec.rs @@ -149,8 +149,7 @@ pub fn from_fn(n_elts: uint, op: old_iter::InitOp) -> ~[T] { do as_mut_buf(v) |p, _len| { let mut i: uint = 0u; while i < n_elts { - intrinsics::move_val_init(&mut(*ptr::mut_offset(p, i)), - op(i)); + intrinsics::move_val_init(&mut(*ptr::mut_offset(p, i)), op(i)); i += 1u; } } @@ -166,7 +165,20 @@ pub fn from_fn(n_elts: uint, op: old_iter::InitOp) -> ~[T] { * to the value `t`. */ pub fn from_elem(n_elts: uint, t: T) -> ~[T] { - from_fn(n_elts, |_i| copy t) + // hack: manually inline from_fn for 2x plus speedup (sadly very important, from_elem is a + // bottleneck in borrowck!) + unsafe { + let mut v = with_capacity(n_elts); + do as_mut_buf(v) |p, _len| { + let mut i = 0u; + while i < n_elts { + intrinsics::move_val_init(&mut(*ptr::mut_offset(p, i)), copy t); + i += 1u; + } + } + raw::set_len(&mut v, n_elts); + v + } } /// Creates a new unique vector with the same contents as the slice