From 73d4330ff8fd0ee0aa88739393d1ab5b46fe5e9a Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Tue, 28 Jul 2015 19:54:13 +0200 Subject: [PATCH] Use raw pointers to avoid aliasing violation in split_at_mut Fixes #27357 --- src/libcore/slice.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/libcore/slice.rs b/src/libcore/slice.rs index 00e7ff3c4df82..9b9c61dd6e5fc 100644 --- a/src/libcore/slice.rs +++ b/src/libcore/slice.rs @@ -288,11 +288,12 @@ impl SliceExt for [T] { #[inline] fn split_at_mut(&mut self, mid: usize) -> (&mut [T], &mut [T]) { + let len = self.len(); + let ptr = self.as_mut_ptr(); + assert!(mid <= len); unsafe { - let self2: &mut [T] = mem::transmute_copy(&self); - - (ops::IndexMut::index_mut(self, ops::RangeTo { end: mid } ), - ops::IndexMut::index_mut(self2, ops::RangeFrom { start: mid } )) + (from_raw_parts_mut(ptr, mid), + from_raw_parts_mut(ptr.offset(mid as isize), len - mid)) } }