From fb64c7b321c34e0c7c2ba1bb576dc53daa31b6be Mon Sep 17 00:00:00 2001 From: Brian Anderson Date: Wed, 15 Apr 2015 13:21:18 -0700 Subject: [PATCH 1/2] configure: Don't succeed if valgrind isn't available. Fixes #18588 Based on @emanueLczirai's patch. --- configure | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/configure b/configure index 18fef588936e7..276b7167e2c26 100755 --- a/configure +++ b/configure @@ -750,6 +750,15 @@ then fi fi +# By default the test suite *requires* valgrind. Detect it's absence. +if [ -z "$CFG_VALGRIND" ] +then + if [ ! -z "$CFG_ENABLE_VALGRIND" ] || [ -z "$CFG_DISABLE_VALGRIND_RPASS" ] + then + err "valgrind not found, but needed. consider adding --disable-valgrind-rpass" + fi +fi + step_msg "looking for target specific programs" probe CFG_ADB adb From 31856a5209a8a5c011ee45c559959187bc058962 Mon Sep 17 00:00:00 2001 From: Brian Anderson Date: Wed, 22 Apr 2015 15:34:57 -0700 Subject: [PATCH 2/2] Typo --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 276b7167e2c26..226ab21211f58 100755 --- a/configure +++ b/configure @@ -750,7 +750,7 @@ then fi fi -# By default the test suite *requires* valgrind. Detect it's absence. +# By default the test suite *requires* valgrind. Detect its absence. if [ -z "$CFG_VALGRIND" ] then if [ ! -z "$CFG_ENABLE_VALGRIND" ] || [ -z "$CFG_DISABLE_VALGRIND_RPASS" ]