Avoid higher-order functions to get item attributes. #20957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Using a closure unnecessarily obfuscates the code.
Using a closure unnecessarily obfuscates the code.
Contributor
Author
|
re-r? @alexcrichton |
bors
added a commit
that referenced
this pull request
Jan 13, 2015
Returning the vectors directly makes the code a lot cleaner.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Nov 4, 2025
Fix missing other assoc items for generate_blanket_trait_impl
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Nov 11, 2025
Fix missing other assoc items for generate_blanket_trait_impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning the vectors directly makes the code a lot cleaner.