-
Notifications
You must be signed in to change notification settings - Fork 14k
Use yarn instead of npm for JS/TS dependencies
#148763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yarn instead of npm for JS/TS dependencies
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update Some changes occurred in HTML/CSS/JS. |
|
r? @clubby789 rustbot has assigned @clubby789. Use |
|
r? @Kobzol since you're already kinda familiar with the situation? (maybe also @notriddle for the small TS fixes, if you can take a look) |
|
|
|
☔ The latest upstream changes (presumably #148885) made this pull request unmergeable. Please resolve the merge conflicts. |
…rors that started popping when we moved to `yarn` Updating `es-check` managed to solve a problem about a missing type file for `minimatch` which I couldn't get around any other way
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Since we install |
|
Apparently, nowadays npm is not the recommended way to install yarn either. Personally, I think it's fine to expect the few folks actually running tidy's JS (extra)checks to install yarn, if that means we can avoid adding more complexity to tidy. Regardless of what we choose, I should probably try to modify this PR to install yarn via the new recommended way. |
|
If we want to automatically install yarn, I think we should do a bit of design work. Ideally, for everything that we download/install automatically, there would also be a bootstrap config option to specify it's path manually, so that everything can be done offline in something like a nix derivation. Currently it's not a huge deal bc the only thing we're downloading for without a config option is testing, not building, but it would still be nice. |
Building on @lolbinarycat 's excellent work ( #148672 ).
npmapparently has certain edge-cases where it doesn't actually respect the lockfile it's fed, which has led to at least one CI breakage.yarnseems to not suffer from those same issues, and also has a--frozenflag for itsinstallcommand