Improve diagnostics for buffer reuse with borrowed references #147974
+185
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This PR modifies |
rustbot
added
S-waiting-on-review
Collaborator
Member
Author
|
r? @estebank |
JohnTitor
commented
Oct 22, 2025
| ) | ||
| ); | ||
| err.help( | ||
| "buffer reuse with borrowed references requires unsafe code or restructuring" |
Member
Author
There was a problem hiding this comment.
Didn't mention recycle_vec as I'm not sure if using that crate is the most common solution here.
Contributor
There was a problem hiding this comment.
There's an RFC to bring that into std, so we can change this once we have that.
estebank
reviewed
Nov 11, 2025
Comment on lines
+27
to
+28
| LL | buffer.clear(); | ||
| | ------ borrow later used here |
Contributor
There was a problem hiding this comment.
This is specifically (one of) the pattern(s) that we should detect in order to suggest recycling in the future.
Contributor
|
@bors r+ Leaving the ticket open to not forget to come back to this and provide structured suggestions when possible. Thank you for taking a look at this! |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 11, 2025
…ttern, r=estebank Improve diagnostics for buffer reuse with borrowed references Addresses rust-lang#147694 I'm not sure the current note wording is the best so I appreciate any feedback.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 11, 2025
…ttern, r=estebank Improve diagnostics for buffer reuse with borrowed references Addresses rust-lang#147694 I'm not sure the current note wording is the best so I appreciate any feedback.
bors
added a commit
that referenced
this pull request
Nov 12, 2025
Rollup of 12 pull requests Successful merges: - #146627 (Simplify `jemalloc` setup) - #147753 (Suggest add bounding value for RangeTo) - #147974 (Improve diagnostics for buffer reuse with borrowed references) - #148080 ([rustdoc] Fix invalid jump to def macro link generation) - #148424 (bootstrap: Add snapshot tests for path-to-step handling) - #148500 (Update git index before running diff-index) - #148536 (cmse: add test for `async` and `const` functions) - #148770 (implement `feature(c_variadic_naked_functions)`) - #148819 (Remove specialized warning for removed target) - #148830 (miri subtree update) - #148833 (Update rustbook dependencies) - #148841 (Remove more `#[must_use]` from portable-simd) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
bors
added a commit
that referenced
this pull request
Nov 12, 2025
…tebank Improve diagnostics for buffer reuse with borrowed references Addresses #147694 I'm not sure the current note wording is the best so I appreciate any feedback.
Member
|
Yielding to enclosing rollup. @bors retry |
bors
added a commit
that referenced
this pull request
Nov 12, 2025
Rollup of 16 pull requests Successful merges: - #146627 (Simplify `jemalloc` setup) - #147753 (Suggest add bounding value for RangeTo) - #147832 (rustdoc: Don't pass `RenderOptions` to `DocContext`) - #147974 (Improve diagnostics for buffer reuse with borrowed references) - #148080 ([rustdoc] Fix invalid jump to def macro link generation) - #148465 (Adjust spans into the `for` loops context before creating the new desugaring spans.) - #148500 (Update git index before running diff-index) - #148531 (rustc_target: introduce Abi, Env, Os) - #148536 (cmse: add test for `async` and `const` functions) - #148770 (implement `feature(c_variadic_naked_functions)`) - #148780 (fix filecheck typos in tests) - #148819 (Remove specialized warning for removed target) - #148830 (miri subtree update) - #148833 (Update rustbook dependencies) - #148834 (fix(rustdoc): Color doctest errors) - #148841 (Remove more `#[must_use]` from portable-simd) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 12, 2025
Rollup of 16 pull requests Successful merges: - rust-lang/rust#146627 (Simplify `jemalloc` setup) - rust-lang/rust#147753 (Suggest add bounding value for RangeTo) - rust-lang/rust#147832 (rustdoc: Don't pass `RenderOptions` to `DocContext`) - rust-lang/rust#147974 (Improve diagnostics for buffer reuse with borrowed references) - rust-lang/rust#148080 ([rustdoc] Fix invalid jump to def macro link generation) - rust-lang/rust#148465 (Adjust spans into the `for` loops context before creating the new desugaring spans.) - rust-lang/rust#148500 (Update git index before running diff-index) - rust-lang/rust#148531 (rustc_target: introduce Abi, Env, Os) - rust-lang/rust#148536 (cmse: add test for `async` and `const` functions) - rust-lang/rust#148770 (implement `feature(c_variadic_naked_functions)`) - rust-lang/rust#148780 (fix filecheck typos in tests) - rust-lang/rust#148819 (Remove specialized warning for removed target) - rust-lang/rust#148830 (miri subtree update) - rust-lang/rust#148833 (Update rustbook dependencies) - rust-lang/rust#148834 (fix(rustdoc): Color doctest errors) - rust-lang/rust#148841 (Remove more `#[must_use]` from portable-simd) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #147694
I'm not sure the current note wording is the best so I appreciate any feedback.