From 8fc1bed0c8b6aab76d07e7576b0c1c1f29b934bf Mon Sep 17 00:00:00 2001 From: Jake Goulding Date: Thu, 29 May 2025 09:38:44 -0400 Subject: [PATCH] Reduce confusion of some drop order tests In addition to adhering to normal Rust casing idioms, I ran `rustfmt`. --- tests/ui/drop/issue-2735-2.rs | 13 +++++-------- tests/ui/drop/issue-2735-3.rs | 11 ++++------- tests/ui/drop/issue-2735.rs | 12 +++++------- tests/ui/drop/issue-979.rs | 11 ++++------- 4 files changed, 18 insertions(+), 29 deletions(-) diff --git a/tests/ui/drop/issue-2735-2.rs b/tests/ui/drop/issue-2735-2.rs index 66025956e0880..43fbafe7a0e07 100644 --- a/tests/ui/drop/issue-2735-2.rs +++ b/tests/ui/drop/issue-2735-2.rs @@ -1,27 +1,24 @@ //@ run-pass -#![allow(non_camel_case_types)] use std::cell::Cell; // This test should behave exactly like issue-2735-3 -struct defer<'a> { +struct Defer<'a> { b: &'a Cell, } -impl<'a> Drop for defer<'a> { +impl<'a> Drop for Defer<'a> { fn drop(&mut self) { self.b.set(true); } } -fn defer(b: &Cell) -> defer<'_> { - defer { - b: b - } +fn defer(b: &Cell) -> Defer<'_> { + Defer { b } } pub fn main() { let dtor_ran = &Cell::new(false); - let _ = defer(dtor_ran); + let _ = defer(dtor_ran); assert!(dtor_ran.get()); } diff --git a/tests/ui/drop/issue-2735-3.rs b/tests/ui/drop/issue-2735-3.rs index c9535168653cf..cc28f96d2b03e 100644 --- a/tests/ui/drop/issue-2735-3.rs +++ b/tests/ui/drop/issue-2735-3.rs @@ -1,23 +1,20 @@ //@ run-pass -#![allow(non_camel_case_types)] use std::cell::Cell; // This test should behave exactly like issue-2735-2 -struct defer<'a> { +struct Defer<'a> { b: &'a Cell, } -impl<'a> Drop for defer<'a> { +impl<'a> Drop for Defer<'a> { fn drop(&mut self) { self.b.set(true); } } -fn defer(b: &Cell) -> defer<'_> { - defer { - b: b - } +fn defer(b: &Cell) -> Defer<'_> { + Defer { b } } pub fn main() { diff --git a/tests/ui/drop/issue-2735.rs b/tests/ui/drop/issue-2735.rs index cd7e0b8f46109..838b9da109b1f 100644 --- a/tests/ui/drop/issue-2735.rs +++ b/tests/ui/drop/issue-2735.rs @@ -1,15 +1,13 @@ //@ run-pass #![allow(dead_code)] -#![allow(non_camel_case_types)] - -trait hax { - fn dummy(&self) { } +trait Hax { + fn dummy(&self) {} } -impl hax for A { } +impl Hax for A {} -fn perform_hax(x: Box) -> Box { - Box::new(x) as Box +fn perform_hax(x: Box) -> Box { + Box::new(x) as Box } fn deadcode() { diff --git a/tests/ui/drop/issue-979.rs b/tests/ui/drop/issue-979.rs index 70052708be6c4..abbcc71de18c9 100644 --- a/tests/ui/drop/issue-979.rs +++ b/tests/ui/drop/issue-979.rs @@ -1,22 +1,19 @@ //@ run-pass -#![allow(non_camel_case_types)] use std::cell::Cell; -struct r<'a> { +struct R<'a> { b: &'a Cell, } -impl<'a> Drop for r<'a> { +impl<'a> Drop for R<'a> { fn drop(&mut self) { self.b.set(self.b.get() + 1); } } -fn r(b: &Cell) -> r<'_> { - r { - b: b - } +fn r(b: &Cell) -> R<'_> { + R { b } } pub fn main() {