Skip to content

Commit cbcc8f7

Browse files
committed
f16_f128: enable some more tests in Miri
1 parent 4cd91ef commit cbcc8f7

File tree

1 file changed

+14
-15
lines changed
  • library/coretests/tests/floats

1 file changed

+14
-15
lines changed

library/coretests/tests/floats/mod.rs

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1180,13 +1180,11 @@ float_test! {
11801180
}
11811181
}
11821182

1183-
// FIXME(f16_f128,miri): many of these have to be disabled since miri does not yet support
1184-
// the intrinsics.
1185-
11861183
float_test! {
11871184
name: sqrt_domain,
11881185
attrs: {
11891186
const: #[cfg(false)],
1187+
// FIXME(f16_f128): `sqrt` does not work in Miri for these types
11901188
f16: #[cfg(all(not(miri), target_has_reliable_f16_math))],
11911189
f128: #[cfg(all(not(miri), target_has_reliable_f128_math))],
11921190
},
@@ -1247,8 +1245,8 @@ float_test! {
12471245
name: total_cmp,
12481246
attrs: {
12491247
const: #[cfg(false)],
1250-
f16: #[cfg(all(not(miri), target_has_reliable_f16_math))],
1251-
f128: #[cfg(all(not(miri), target_has_reliable_f128_math))],
1248+
f16: #[cfg(any(miri, target_has_reliable_f16_math))],
1249+
f128: #[cfg(any(miri, target_has_reliable_f128_math))],
12521250
},
12531251
test<Float> {
12541252
use core::cmp::Ordering;
@@ -1356,8 +1354,8 @@ float_test! {
13561354
name: total_cmp_s_nan,
13571355
attrs: {
13581356
const: #[cfg(false)],
1359-
f16: #[cfg(false)],
1360-
f128: #[cfg(all(not(miri), target_has_reliable_f128_math))],
1357+
f16: #[cfg(miri)],
1358+
f128: #[cfg(any(miri, target_has_reliable_f128_math))],
13611359
},
13621360
test<Float> {
13631361
use core::cmp::Ordering;
@@ -1433,6 +1431,7 @@ float_test! {
14331431
name: powi,
14341432
attrs: {
14351433
const: #[cfg(false)],
1434+
// FIXME(f16_f128): `powi` does not work in Miri for these types
14361435
f16: #[cfg(all(not(miri), target_has_reliable_f16_math))],
14371436
f128: #[cfg(all(not(miri), target_has_reliable_f128_math))],
14381437
},
@@ -1453,8 +1452,8 @@ float_test! {
14531452
float_test! {
14541453
name: to_degrees,
14551454
attrs: {
1456-
f16: #[cfg(target_has_reliable_f16)],
1457-
f128: #[cfg(target_has_reliable_f128)],
1455+
f16: #[cfg(any(miri, target_has_reliable_f16))],
1456+
f128: #[cfg(any(miri, target_has_reliable_f128))],
14581457
},
14591458
test<Float> {
14601459
let pi: Float = Float::PI;
@@ -1474,8 +1473,8 @@ float_test! {
14741473
float_test! {
14751474
name: to_radians,
14761475
attrs: {
1477-
f16: #[cfg(target_has_reliable_f16)],
1478-
f128: #[cfg(target_has_reliable_f128)],
1476+
f16: #[cfg(any(miri, target_has_reliable_f16))],
1477+
f128: #[cfg(any(miri, target_has_reliable_f128))],
14791478
},
14801479
test<Float> {
14811480
let pi: Float = Float::PI;
@@ -1495,8 +1494,8 @@ float_test! {
14951494
float_test! {
14961495
name: to_algebraic,
14971496
attrs: {
1498-
f16: #[cfg(target_has_reliable_f16)],
1499-
f128: #[cfg(target_has_reliable_f128)],
1497+
f16: #[cfg(any(miri, target_has_reliable_f16))],
1498+
f128: #[cfg(any(miri, target_has_reliable_f128))],
15001499
},
15011500
test<Float> {
15021501
let a: Float = 123.0;
@@ -1519,8 +1518,8 @@ float_test! {
15191518
float_test! {
15201519
name: to_bits_conv,
15211520
attrs: {
1522-
f16: #[cfg(target_has_reliable_f16)],
1523-
f128: #[cfg(target_has_reliable_f128)],
1521+
f16: #[cfg(any(miri, target_has_reliable_f16))],
1522+
f128: #[cfg(any(miri, target_has_reliable_f128))],
15241523
},
15251524
test<Float> {
15261525
assert_biteq!(flt(1.0), Float::RAW_1);

0 commit comments

Comments
 (0)