Don't use inline(never)

Author: orlp

library/std/src/sys/thread_local/key/racy.rs

@@ -34,7 +34,7 @@ impl LazyKey {
         LazyKey { key: AtomicUsize::new(KEY_SENTVAL), dtor }
     }
 
-    #[inline(always)]
+    #[inline]
     pub fn force(&self) -> super::Key {
         match self.key.load(Ordering::Acquire) {
             KEY_SENTVAL => self.lazy_init() as super::Key,
@@ -43,7 +43,6 @@ impl LazyKey {
     }
 
     #[cold]
-    #[inline(never)]
     fn lazy_init(&self) -> usize {
         // POSIX allows the key created here to be KEY_SENTVAL, but the compare_exchange
         // below relies on using KEY_SENTVAL as a sentinel value to check who won the

library/std/src/sys/thread_local/key/windows.rs

@@ -58,7 +58,7 @@ impl LazyKey {
         }
     }
 
-    #[inline(always)]
+    #[inline]
     pub fn force(&'static self) -> Key {
         match self.key.load(Acquire) {
             0 => unsafe { self.init() },
@@ -67,7 +67,6 @@ impl LazyKey {
     }
 
     #[cold]
-    #[inline(never)]
     unsafe fn init(&'static self) -> Key {
         if self.dtor.is_some() {
             let mut pending = c::FALSE;

library/std/src/sys/thread_local/key/xous.rs

@@ -93,7 +93,6 @@ fn tls_table() -> &'static mut [*mut u8] {
 }
 
 #[cold]
-#[inline(never)]
 fn tls_table_slow() -> &'static mut [*mut u8] {
     // If the TP register is `0`, then this thread hasn't initialized
     // its TLS yet. Allocate a new page to store this memory.

library/std/src/sys/thread_local/native/eager.rs

@@ -28,7 +28,7 @@ impl<T> Storage<T> {
     ///
     /// # Safety
     /// The `self` reference must remain valid until the TLS destructor is run.
-    #[inline(always)]
+    #[inline]
     pub unsafe fn get(&self) -> *const T {
         if let State::Alive = self.state.get() {
             self.val.get()
@@ -38,7 +38,6 @@ impl<T> Storage<T> {
     }
 
     #[cold]
-    #[inline(never)]
     unsafe fn get_or_init_slow(&self) -> *const T {
         match self.state.get() {
             State::Uninitialized => {}

library/std/src/sys/thread_local/native/lazy.rs

@@ -52,7 +52,7 @@ where
     ///
     /// # Safety
     /// The `self` reference must remain valid until the TLS destructor is run.
-    #[inline(always)]
+    #[inline]
     pub unsafe fn get_or_init(&self, i: Option<&mut Option<T>>, f: impl FnOnce() -> T) -> *const T {
         if let State::Alive = self.state.get() {
             self.value.get().cast()
@@ -64,7 +64,6 @@ where
     /// # Safety
     /// The `self` reference must remain valid until the TLS destructor is run.
     #[cold]
-    #[inline(never)]
     unsafe fn get_or_init_slow(
         &self,
         i: Option<&mut Option<T>>,

library/std/src/sys/thread_local/os.rs

@@ -86,7 +86,6 @@ impl<T: 'static> Storage<T> {
     /// * `key` must be the result of calling `self.key.force()`
     /// * `ptr` must be the current value associated with `key`.
     #[cold]
-    #[inline(never)]
     unsafe fn try_initialize(
         key: Key,
         ptr: *mut Value<T>,