fixed reviews

Author: Kivooeo

tests/ui/enum/enum-drop-cast-error.rs

@@ -1,4 +1,6 @@
-//! Ensures safe handling of enums with `Drop` by preventing integer casts.
+//! Check that trying to cast an enum with a Drop impl to an integer is rejected.
+//!
+//! Issue: <https://github.com/rust-lang/rust/issues/35941>
 
 enum E {
     A = 0,

tests/ui/lifetimes/rvalue-lifetime-for-loop.rs

@@ -1,65 +1,32 @@
-//! Test that the lifetime of rvalues in for loops is extended
-//! to the for loop itself.
+//! Check that temporaries in the for into-iterable expr are not dropped
+//! until the end of the for expr.
 
 //@ run-pass
 
-#![allow(non_snake_case)]
-#![allow(dead_code)]
-#![allow(unused_variables)]
-
 static mut FLAGS: u64 = 0;
 
-struct Box<T> {
-    f: T,
-}
 struct AddFlags {
     bits: u64,
 }
 
-fn AddFlags(bits: u64) -> AddFlags {
-    AddFlags { bits }
-}
-
-fn arg(exp: u64, _x: &AddFlags) {
-    check_flags(exp);
-}
-
-fn pass<T>(v: T) -> T {
-    v
-}
-
-fn check_flags(exp: u64) {
-    unsafe {
-        let x = FLAGS;
-        FLAGS = 0;
-        println!("flags {}, expected {}", x, exp);
-        assert_eq!(x, exp);
-    }
-}
-
-impl AddFlags {
-    fn check_flags(&self, exp: u64) -> &AddFlags {
-        check_flags(exp);
-        self
-    }
-
-    fn bits(&self) -> u64 {
-        self.bits
-    }
-}
-
 impl Drop for AddFlags {
     fn drop(&mut self) {
         unsafe {
-            FLAGS = FLAGS + self.bits;
+            FLAGS += self.bits;
         }
     }
 }
 
-pub fn main() {
-    // The array containing [AddFlags] should not be dropped until
-    // after the for loop:
-    for x in &[AddFlags(1)] {
+fn check_flags(expected: u64) {
+    unsafe {
+        let actual = FLAGS;
+        FLAGS = 0;
+        assert_eq!(actual, expected, "flags {}, expected {}", actual, expected);
+    }
+}
+
+fn main() {
+    for _ in &[AddFlags { bits: 1 }] {
         check_flags(0);
     }
     check_flags(1);

tests/ui/privacy/trait-object-method-error.rs

@@ -0,0 +1,20 @@
+//! Trait objects only allow access to methods defined in the trait.
+
+trait MyTrait {
+    fn do_something(&mut self);
+}
+
+struct ImplType;
+
+impl MyTrait for ImplType {
+    fn do_something(&mut self) {}
+}
+
+impl ImplType {
+    fn extra_method(&mut self) {}
+}
+
+fn main() {
+    let obj: Box<dyn MyTrait> = Box::new(ImplType);
+    obj.extra_method(); //~ ERROR no method named `extra_method` found
+}

tests/ui/privacy/trait-object-method-error.stderr

@@ -0,0 +1,9 @@
+error[E0599]: no method named `extra_method` found for struct `Box<dyn MyTrait>` in the current scope
+  --> $DIR/trait-object-method-error.rs:19:9
+   |
+LL |     obj.extra_method();
+   |         ^^^^^^^^^^^^ method not found in `Box<dyn MyTrait>`
+
+error: aborting due to 1 previous error
+
+For more information about this error, try `rustc --explain E0599`.

tests/ui/traits/trait-impl-missing-method.rs

@@ -1,21 +1,13 @@
-//! Ensures trait implementations provide all required methods.
+//! Trait impls must define all required methods.
 
-trait Animal {
-    fn eat(&self);
+trait MyTrait {
+    fn do_something(&self);
 }
 
-struct Cat {
-    meows: usize,
-}
-
-impl Animal for Cat {
-    //~^ ERROR not all trait items implemented, missing: `eat`
-}
+struct ImplType;
 
-fn cat(in_x: usize) -> Cat {
-    Cat { meows: in_x }
-}
+impl MyTrait for ImplType {} //~ ERROR not all trait items implemented, missing: `do_something`
 
 fn main() {
-    let nyan = cat(0);
+    let _ = ImplType;
 }

tests/ui/traits/trait-impl-missing-method.stderr

@@ -1,11 +1,11 @@
-error[E0046]: not all trait items implemented, missing: `eat`
-  --> $DIR/trait-impl-missing-method.rs:11:1
+error[E0046]: not all trait items implemented, missing: `do_something`
+  --> $DIR/trait-impl-missing-method.rs:9:1
    |
-LL |     fn eat(&self);
-   |     -------------- `eat` from trait
+LL |     fn do_something(&self);
+   |     ----------------------- `do_something` from trait
 ...
-LL | impl Animal for Cat {
-   | ^^^^^^^^^^^^^^^^^^^ missing `eat` in implementation
+LL | impl MyTrait for ImplType {}
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^ missing `do_something` in implementation
 
 error: aborting due to 1 previous error