Deprecates needless-maybe-sized in clippy

- Uses clippy dev tool to rename and deprecate needless-maybe-sized in
  clippy.
- Removes needless-maybe-sized from late pass lint register.

Author: CrooseGit

src/tools/clippy/clippy_lints/src/declared_lints.rs

@@ -548,7 +548,6 @@ pub static LINTS: &[&::declare_clippy_lint::LintInfo] = &[
     crate::needless_for_each::NEEDLESS_FOR_EACH_INFO,
     crate::needless_if::NEEDLESS_IF_INFO,
     crate::needless_late_init::NEEDLESS_LATE_INIT_INFO,
-    crate::needless_maybe_sized::NEEDLESS_MAYBE_SIZED_INFO,
     crate::needless_parens_on_range_literals::NEEDLESS_PARENS_ON_RANGE_LITERALS_INFO,
     crate::needless_pass_by_ref_mut::NEEDLESS_PASS_BY_REF_MUT_INFO,
     crate::needless_pass_by_value::NEEDLESS_PASS_BY_VALUE_INFO,

src/tools/clippy/clippy_lints/src/deprecated_lints.rs

@@ -138,6 +138,8 @@ declare_with_version! { RENAMED(RENAMED_VERSION) = [
     ("clippy::mem_discriminant_non_enum", "enum_intrinsics_non_enums"),
     #[clippy::version = "1.80.0"]
     ("clippy::mismatched_target_os", "unexpected_cfgs"),
+    #[clippy::version = "1.90.0"]
+    ("clippy::needless_maybe_sized", "redundant_sizedness_bound"),
     #[clippy::version = ""]
     ("clippy::new_without_default_derive", "clippy::new_without_default"),
     #[clippy::version = ""]

src/tools/clippy/clippy_lints/src/disallowed_macros.rs

@@ -1,4 +1,3 @@
-
 use clippy_config::Conf;
 use clippy_config::types::{DisallowedPath, create_disallowed_map};
 use clippy_utils::diagnostics::{span_lint_and_then, span_lint_hir_and_then};

src/tools/clippy/clippy_lints/src/lib.rs

@@ -264,7 +264,6 @@ mod needless_else;
 mod needless_for_each;
 mod needless_if;
 mod needless_late_init;
-mod needless_maybe_sized;
 mod needless_parens_on_range_literals;
 mod needless_pass_by_ref_mut;
 mod needless_pass_by_value;
@@ -741,7 +740,6 @@ pub fn register_lint_passes(store: &mut rustc_lint::LintStore, conf: &'static Co
     store.register_late_pass(|_| Box::new(no_mangle_with_rust_abi::NoMangleWithRustAbi));
     store.register_late_pass(|_| Box::new(collection_is_never_read::CollectionIsNeverRead));
     store.register_late_pass(|_| Box::new(missing_assert_message::MissingAssertMessage));
-    store.register_late_pass(|_| Box::new(needless_maybe_sized::NeedlessMaybeSized));
     store.register_late_pass(|_| Box::new(redundant_async_block::RedundantAsyncBlock));
     store.register_late_pass(|_| Box::new(let_with_type_underscore::UnderscoreTyped));
     store.register_late_pass(move |_| Box::new(manual_main_separator_str::ManualMainSeparatorStr::new(conf)));

src/tools/clippy/clippy_lints/src/needless_maybe_sized.rs

@@ -7,31 +7,7 @@ use rustc_middle::ty::{ClauseKind, PredicatePolarity};
 use rustc_session::declare_lint_pass;
 use rustc_span::symbol::Ident;
 
-declare_clippy_lint! {
-    /// ### What it does
-    /// Lints `?Sized` bounds applied to type parameters that cannot be unsized
-    ///
-    /// ### Why is this bad?
-    /// The `?Sized` bound is misleading because it cannot be satisfied by an
-    /// unsized type
-    ///
-    /// ### Example
-    /// ```rust
-    /// // `T` cannot be unsized because `Clone` requires it to be `Sized`
-    /// fn f<T: Clone + ?Sized>(t: &T) {}
-    /// ```
-    /// Use instead:
-    /// ```rust
-    /// fn f<T: Clone>(t: &T) {}
-    ///
-    /// // or choose alternative bounds for `T` so that it can be unsized
-    /// ```
-    #[clippy::version = "1.81.0"]
-    pub NEEDLESS_MAYBE_SIZED,
-    suspicious,
-    "a `?Sized` bound that is unusable due to a `Sized` requirement"
-}
-declare_lint_pass!(NeedlessMaybeSized => [NEEDLESS_MAYBE_SIZED]);
+declare_lint_pass!(RedundantSizednessBound => [REDUNDANT_SIZEDNESS_BOUND]);
 
 #[allow(clippy::struct_field_names)]
 struct Bound<'tcx> {
@@ -109,7 +85,7 @@ fn path_to_sized_bound(cx: &LateContext<'_>, trait_bound: &PolyTraitRef<'_>) ->
     search(cx, &mut path).then_some(path)
 }
 
-impl LateLintPass<'_> for NeedlessMaybeSized {
+impl LateLintPass<'_> for RedundantSizednessBound {
     fn check_generics(&mut self, cx: &LateContext<'_>, generics: &Generics<'_>) {
         let Some(sized_trait) = cx.tcx.lang_items().sized_trait() else {
             return;
@@ -130,7 +106,7 @@ impl LateLintPass<'_> for NeedlessMaybeSized {
             {
                 span_lint_and_then(
                     cx,
-                    NEEDLESS_MAYBE_SIZED,
+                    REDUNDANT_SIZEDNESS_BOUND,
                     sized_bound.trait_bound.span,
                     "`?Sized` bound is ignored because of a `Sized` requirement",
                     |diag| {

src/tools/clippy/tests/ui-toml/type_repetition_in_bounds/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::needless_maybe_sized)]
+#![allow(redundant_sizedness_bound)]
 #![warn(clippy::type_repetition_in_bounds)]
 
 fn f<T>()

src/tools/clippy/tests/ui/derive.rs

@@ -9,7 +9,6 @@
 #![expect(incomplete_features)] // `unsafe_fields` is incomplete for the time being
 #![feature(unsafe_fields)] // `clone()` cannot be derived automatically on unsafe fields
 
-
 #[derive(Copy)]
 struct Qux;
 

src/tools/clippy/tests/ui/derive.stderr

@@ -1,5 +1,5 @@
 error: you are implementing `Clone` explicitly on a `Copy` type
-  --> tests/ui/derive.rs:16:1
+  --> tests/ui/derive.rs:15:1
    |
 LL | / impl Clone for Qux {
 LL | |
@@ -10,7 +10,7 @@ LL | | }
    | |_^
    |
 note: consider deriving `Clone` or removing `Copy`
-  --> tests/ui/derive.rs:16:1
+  --> tests/ui/derive.rs:15:1
    |
 LL | / impl Clone for Qux {
 LL | |
@@ -23,7 +23,7 @@ LL | | }
    = help: to override `-D warnings` add `#[allow(clippy::expl_impl_clone_on_copy)]`
 
 error: you are implementing `Clone` explicitly on a `Copy` type
-  --> tests/ui/derive.rs:42:1
+  --> tests/ui/derive.rs:41:1
    |
 LL | / impl<'a> Clone for Lt<'a> {
 LL | |
@@ -34,7 +34,7 @@ LL | | }
    | |_^
    |
 note: consider deriving `Clone` or removing `Copy`
-  --> tests/ui/derive.rs:42:1
+  --> tests/ui/derive.rs:41:1
    |
 LL | / impl<'a> Clone for Lt<'a> {
 LL | |
@@ -45,7 +45,7 @@ LL | | }
    | |_^
 
 error: you are implementing `Clone` explicitly on a `Copy` type
-  --> tests/ui/derive.rs:55:1
+  --> tests/ui/derive.rs:54:1
    |
 LL | / impl Clone for BigArray {
 LL | |
@@ -56,7 +56,7 @@ LL | | }
    | |_^
    |
 note: consider deriving `Clone` or removing `Copy`
-  --> tests/ui/derive.rs:55:1
+  --> tests/ui/derive.rs:54:1
    |
 LL | / impl Clone for BigArray {
 LL | |
@@ -67,7 +67,7 @@ LL | | }
    | |_^
 
 error: you are implementing `Clone` explicitly on a `Copy` type
-  --> tests/ui/derive.rs:68:1
+  --> tests/ui/derive.rs:67:1
    |
 LL | / impl Clone for FnPtr {
 LL | |
@@ -78,7 +78,7 @@ LL | | }
    | |_^
    |
 note: consider deriving `Clone` or removing `Copy`
-  --> tests/ui/derive.rs:68:1
+  --> tests/ui/derive.rs:67:1
    |
 LL | / impl Clone for FnPtr {
 LL | |
@@ -89,7 +89,7 @@ LL | | }
    | |_^
 
 error: you are implementing `Clone` explicitly on a `Copy` type
-  --> tests/ui/derive.rs:90:1
+  --> tests/ui/derive.rs:89:1
    |
 LL | / impl<T: Clone> Clone for Generic2<T> {
 LL | |
@@ -100,7 +100,7 @@ LL | | }
    | |_^
    |
 note: consider deriving `Clone` or removing `Copy`
-  --> tests/ui/derive.rs:90:1
+  --> tests/ui/derive.rs:89:1
    |
 LL | / impl<T: Clone> Clone for Generic2<T> {
 LL | |

src/tools/clippy/tests/ui/needless_doc_main.rs

@@ -9,23 +9,23 @@
 ///     unimplemented!();
 /// }
 /// ```
-///
+/// 
 /// With an explicit return type it should lint too
 /// ```edition2015
 /// fn main() -> () {
 //~^ ERROR: needless `fn main` in doctest
 ///     unimplemented!();
 /// }
 /// ```
-///
+/// 
 /// This should, too.
 /// ```rust
 /// fn main() {
 //~^ ERROR: needless `fn main` in doctest
 ///     unimplemented!();
 /// }
 /// ```
-///
+/// 
 /// This one too.
 /// ```no_run
 /// // the fn is not always the first line