refactor resource script creation into a separate function

Author: lambdageek

compiler/rustc_windows_rc/src/lib.rs

@@ -38,6 +38,34 @@ pub fn compile_windows_resource_file(
     let resource_compiler =
         find_resource_compiler(&env::var("CARGO_CFG_TARGET_ARCH").unwrap()).expect("found rc.exe");
 
+    let rc_path = resources_dir.join(file_stem.with_extension("rc"));
+
+    write_resource_script_file(&rc_path, file_description, filetype);
+
+    let res_path = resources_dir.join(file_stem.with_extension("res"));
+
+    let status = process::Command::new(resource_compiler)
+        .arg("/fo")
+        .arg(&res_path)
+        .arg(&rc_path)
+        .status()
+        .expect("can execute resource compiler");
+    assert!(status.success(), "rc.exe failed with status {}", status);
+    assert!(
+        res_path.try_exists().unwrap_or(false),
+        "resource file {} was not created",
+        res_path.display()
+    );
+    res_path
+}
+
+/// Writes a Windows resource script file for the rust compiler with the product and file version information
+/// into `rc_path`
+fn write_resource_script_file(
+    rc_path: &path::Path,
+    file_description: &str,
+    filetype: VersionInfoFileType,
+) {
     let mut resource_script = RESOURCE_TEMPLATE.to_string();
 
     // Set the string product and file version to the same thing as `rustc --version`
@@ -62,25 +90,8 @@ pub fn compile_windows_resource_file(
         .replace("@RUSTC_PRODUCTVERSION_QUAD@", &version.to_quad_string())
         .replace("@RUSTC_PRODUCTVERSION_STR@", &descriptive_version);
 
-    let rc_path = resources_dir.join(file_stem.with_extension("rc"));
     fs::write(&rc_path, resource_script)
         .unwrap_or_else(|_| panic!("failed to write resource file {}", rc_path.display()));
-
-    let res_path = resources_dir.join(file_stem.with_extension("res"));
-
-    let status = process::Command::new(resource_compiler)
-        .arg("/fo")
-        .arg(&res_path)
-        .arg(&rc_path)
-        .status()
-        .expect("can execute resource compiler");
-    assert!(status.success(), "rc.exe failed with status {}", status);
-    assert!(
-        res_path.try_exists().unwrap_or(false),
-        "resource file {} was not created",
-        res_path.display()
-    );
-    res_path
 }
 
 fn product_name(channel: String) -> String {