Skip to content

Commit 59ebd64

Browse files
EliasHolzmannEliasHolzmann
committed
Fixed mir-opt test broken because of std::Formatter changes
1 parent 973ce00 commit 59ebd64

File tree

2 files changed

+192
-26
lines changed

2 files changed

+192
-26
lines changed

‎tests/mir-opt/funky_arms.float_to_exponential_common.GVN.panic-abort.diff‎

Lines changed: 96 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,29 +28,70 @@
2828
scope 3 {
2929
debug precision => _8;
3030
let _8: usize;
31-
scope 5 (inlined Formatter::<'_>::precision) {
31+
scope 12 (inlined Formatter::<'_>::precision) {
3232
debug self => _1;
33+
let mut _30: &std::fmt::FormattingOptions;
34+
scope 13 (inlined FormattingOptions::get_precision) {
35+
debug self => _30;
36+
}
3337
}
3438
}
3539
}
3640
}
3741
scope 4 (inlined Formatter::<'_>::sign_plus) {
3842
debug self => _1;
39-
let mut _20: u32;
40-
let mut _21: u32;
43+
let mut _20: &std::option::Option<std::fmt::Sign>;
44+
let _21: std::option::Option<std::fmt::Sign>;
45+
let mut _22: &std::fmt::FormattingOptions;
46+
let mut _23: &std::option::Option<std::fmt::Sign>;
47+
scope 5 (inlined FormattingOptions::get_sign) {
48+
debug self => _22;
49+
}
50+
scope 6 (inlined <Option<std::fmt::Sign> as PartialEq>::eq) {
51+
debug self => _20;
52+
debug other => const _;
53+
scope 7 (inlined <std::fmt::Sign as SpecOptionPartialEq>::eq) {
54+
debug l => _20;
55+
debug r => const _;
56+
let mut _24: isize;
57+
let _25: &std::fmt::Sign;
58+
let _26: &std::fmt::Sign;
59+
let mut _27: &std::fmt::Sign;
60+
let mut _28: &std::fmt::Sign;
61+
scope 8 {
62+
debug l => _25;
63+
debug r => _26;
64+
scope 9 (inlined <std::fmt::Sign as PartialEq>::eq) {
65+
debug self => _27;
66+
debug other => _28;
67+
let _29: isize;
68+
scope 10 {
69+
debug __self_tag => _29;
70+
scope 11 {
71+
debug __arg1_tag => const 0_isize;
72+
}
73+
}
74+
}
75+
}
76+
}
77+
}
4178
}
4279

4380
bb0: {
4481
StorageLive(_4);
82+
- StorageLive(_23);
83+
+ nop;
4584
StorageLive(_20);
4685
StorageLive(_21);
47-
_21 = ((*_1).0: u32);
48-
_20 = BitAnd(move _21, const 1_u32);
49-
StorageDead(_21);
50-
_4 = Ne(move _20, const 0_u32);
51-
StorageDead(_20);
52-
StorageLive(_5);
53-
switchInt(_4) -> [0: bb2, otherwise: bb1];
86+
StorageLive(_22);
87+
_22 = &((*_1).0: std::fmt::FormattingOptions);
88+
_21 = (((*_1).0: std::fmt::FormattingOptions).0: std::option::Option<std::fmt::Sign>);
89+
_20 = &_21;
90+
StorageDead(_22);
91+
_23 = const _;
92+
StorageLive(_24);
93+
_24 = discriminant(_21);
94+
switchInt(move _24) -> [0: bb10, 1: bb11, otherwise: bb12];
5495
}
5596

5697
bb1: {
@@ -60,14 +101,17 @@
60101
}
61102

62103
bb2: {
63-
- _5 = Minus;
64-
+ _5 = const Minus;
104+
- _5 = core::num::flt2dec::Sign::Minus;
105+
+ _5 = const core::num::flt2dec::Sign::Minus;
65106
goto -> bb3;
66107
}
67108

68109
bb3: {
69110
StorageLive(_6);
70-
_6 = ((*_1).4: std::option::Option<usize>);
111+
StorageLive(_30);
112+
_30 = &((*_1).0: std::fmt::FormattingOptions);
113+
_6 = (((*_1).0: std::fmt::FormattingOptions).6: std::option::Option<usize>);
114+
StorageDead(_30);
71115
_7 = discriminant(_6);
72116
switchInt(move _7) -> [1: bb4, otherwise: bb6];
73117
}
@@ -107,5 +151,44 @@
107151
StorageDead(_6);
108152
return;
109153
}
154+
155+
bb9: {
156+
StorageDead(_24);
157+
StorageDead(_20);
158+
StorageDead(_21);
159+
- StorageDead(_23);
160+
+ nop;
161+
StorageLive(_5);
162+
switchInt(_4) -> [0: bb2, otherwise: bb1];
163+
}
164+
165+
bb10: {
166+
_4 = const false;
167+
goto -> bb9;
168+
}
169+
170+
bb11: {
171+
StorageLive(_25);
172+
_25 = &((_21 as Some).0: std::fmt::Sign);
173+
StorageLive(_26);
174+
_26 = &(((*_23) as Some).0: std::fmt::Sign);
175+
StorageLive(_27);
176+
_27 = &((_21 as Some).0: std::fmt::Sign);
177+
StorageLive(_28);
178+
_28 = &(((*_23) as Some).0: std::fmt::Sign);
179+
StorageLive(_29);
180+
_29 = discriminant(((_21 as Some).0: std::fmt::Sign));
181+
_4 = Eq(_29, const 0_isize);
182+
StorageDead(_29);
183+
StorageDead(_28);
184+
StorageDead(_27);
185+
StorageDead(_26);
186+
StorageDead(_25);
187+
goto -> bb9;
188+
}
189+
190+
bb12: {
191+
unreachable;
192+
}
110193
}
111194

‎tests/mir-opt/funky_arms.float_to_exponential_common.GVN.panic-unwind.diff‎

Lines changed: 96 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,29 +28,70 @@
2828
scope 3 {
2929
debug precision => _8;
3030
let _8: usize;
31-
scope 5 (inlined Formatter::<'_>::precision) {
31+
scope 12 (inlined Formatter::<'_>::precision) {
3232
debug self => _1;
33+
let mut _30: &std::fmt::FormattingOptions;
34+
scope 13 (inlined FormattingOptions::get_precision) {
35+
debug self => _30;
36+
}
3337
}
3438
}
3539
}
3640
}
3741
scope 4 (inlined Formatter::<'_>::sign_plus) {
3842
debug self => _1;
39-
let mut _20: u32;
40-
let mut _21: u32;
43+
let mut _20: &std::option::Option<std::fmt::Sign>;
44+
let _21: std::option::Option<std::fmt::Sign>;
45+
let mut _22: &std::fmt::FormattingOptions;
46+
let mut _23: &std::option::Option<std::fmt::Sign>;
47+
scope 5 (inlined FormattingOptions::get_sign) {
48+
debug self => _22;
49+
}
50+
scope 6 (inlined <Option<std::fmt::Sign> as PartialEq>::eq) {
51+
debug self => _20;
52+
debug other => const _;
53+
scope 7 (inlined <std::fmt::Sign as SpecOptionPartialEq>::eq) {
54+
debug l => _20;
55+
debug r => const _;
56+
let mut _24: isize;
57+
let _25: &std::fmt::Sign;
58+
let _26: &std::fmt::Sign;
59+
let mut _27: &std::fmt::Sign;
60+
let mut _28: &std::fmt::Sign;
61+
scope 8 {
62+
debug l => _25;
63+
debug r => _26;
64+
scope 9 (inlined <std::fmt::Sign as PartialEq>::eq) {
65+
debug self => _27;
66+
debug other => _28;
67+
let _29: isize;
68+
scope 10 {
69+
debug __self_tag => _29;
70+
scope 11 {
71+
debug __arg1_tag => const 0_isize;
72+
}
73+
}
74+
}
75+
}
76+
}
77+
}
4178
}
4279

4380
bb0: {
4481
StorageLive(_4);
82+
- StorageLive(_23);
83+
+ nop;
4584
StorageLive(_20);
4685
StorageLive(_21);
47-
_21 = ((*_1).0: u32);
48-
_20 = BitAnd(move _21, const 1_u32);
49-
StorageDead(_21);
50-
_4 = Ne(move _20, const 0_u32);
51-
StorageDead(_20);
52-
StorageLive(_5);
53-
switchInt(_4) -> [0: bb2, otherwise: bb1];
86+
StorageLive(_22);
87+
_22 = &((*_1).0: std::fmt::FormattingOptions);
88+
_21 = (((*_1).0: std::fmt::FormattingOptions).0: std::option::Option<std::fmt::Sign>);
89+
_20 = &_21;
90+
StorageDead(_22);
91+
_23 = const _;
92+
StorageLive(_24);
93+
_24 = discriminant(_21);
94+
switchInt(move _24) -> [0: bb10, 1: bb11, otherwise: bb12];
5495
}
5596

5697
bb1: {
@@ -60,14 +101,17 @@
60101
}
61102

62103
bb2: {
63-
- _5 = Minus;
64-
+ _5 = const Minus;
104+
- _5 = core::num::flt2dec::Sign::Minus;
105+
+ _5 = const core::num::flt2dec::Sign::Minus;
65106
goto -> bb3;
66107
}
67108

68109
bb3: {
69110
StorageLive(_6);
70-
_6 = ((*_1).4: std::option::Option<usize>);
111+
StorageLive(_30);
112+
_30 = &((*_1).0: std::fmt::FormattingOptions);
113+
_6 = (((*_1).0: std::fmt::FormattingOptions).6: std::option::Option<usize>);
114+
StorageDead(_30);
71115
_7 = discriminant(_6);
72116
switchInt(move _7) -> [1: bb4, otherwise: bb6];
73117
}
@@ -107,5 +151,44 @@
107151
StorageDead(_6);
108152
return;
109153
}
154+
155+
bb9: {
156+
StorageDead(_24);
157+
StorageDead(_20);
158+
StorageDead(_21);
159+
- StorageDead(_23);
160+
+ nop;
161+
StorageLive(_5);
162+
switchInt(_4) -> [0: bb2, otherwise: bb1];
163+
}
164+
165+
bb10: {
166+
_4 = const false;
167+
goto -> bb9;
168+
}
169+
170+
bb11: {
171+
StorageLive(_25);
172+
_25 = &((_21 as Some).0: std::fmt::Sign);
173+
StorageLive(_26);
174+
_26 = &(((*_23) as Some).0: std::fmt::Sign);
175+
StorageLive(_27);
176+
_27 = &((_21 as Some).0: std::fmt::Sign);
177+
StorageLive(_28);
178+
_28 = &(((*_23) as Some).0: std::fmt::Sign);
179+
StorageLive(_29);
180+
_29 = discriminant(((_21 as Some).0: std::fmt::Sign));
181+
_4 = Eq(_29, const 0_isize);
182+
StorageDead(_29);
183+
StorageDead(_28);
184+
StorageDead(_27);
185+
StorageDead(_26);
186+
StorageDead(_25);
187+
goto -> bb9;
188+
}
189+
190+
bb12: {
191+
unreachable;
192+
}
110193
}
111194

0 commit comments

Comments
 (0)