Remove animation on source sidebar

GuillaumeGomez · GuillaumeGomez · commit 237d62588ddb · 2022-03-19T16:59:56.000+01:00
diff --git a/src/librustdoc/html/static/css/rustdoc.css b/src/librustdoc/html/static/css/rustdoc.css
@@ -400,7 +400,6 @@ nav.sub {
 .source .sidebar > *:not(#sidebar-toggle) {
 	opacity: 0;
 	visibility: hidden;
-	transition: opacity 0.5s;
 }
 
 .source .sidebar.expanded {
@@ -1677,12 +1676,6 @@ details.rustdoc-toggle[open] > summary.hideme::after {
 		display: none;
 	}
 
-	/* It doesn't render well on mobile because of the layout, so better only have the transition
-	on desktop. */
-	.rustdoc.source .sidebar {
-		transition: width .5s;
-	}
-
 	.source .sidebar.expanded {
 		width: 300px;
 	}
diff --git a/src/test/rustdoc-gui/code-sidebar-toggle.goml b/src/test/rustdoc-gui/code-sidebar-toggle.goml
@@ -3,6 +3,5 @@ goto: file://|DOC_PATH|/test_docs/index.html
 click: ".srclink"
 wait-for: "#sidebar-toggle"
 click: "#sidebar-toggle"
-wait-for: 500
 fail: true
 assert-css: ("#source-sidebar", { "left": "-300px" })

Original file line number	Diff line number	Diff line change
`@@ -400,7 +400,6 @@ nav.sub {`
`400`	`400`	`.source .sidebar > *:not(#sidebar-toggle) {`
`401`	`401`	`opacity: 0;`
`402`	`402`	`visibility: hidden;`
`403`		`- transition: opacity 0.5s;`
`404`	`403`	`}`
`405`	`404`
`406`	`405`	`.source .sidebar.expanded {`
`@@ -1677,12 +1676,6 @@ details.rustdoc-toggle[open] > summary.hideme::after {`
`1677`	`1676`	`display: none;`
`1678`	`1677`	`}`
`1679`	`1678`
`1680`		`- /* It doesn't render well on mobile because of the layout, so better only have the transition`
`1681`		`- on desktop. */`
`1682`		`- .rustdoc.source .sidebar {`
`1683`		`- transition: width .5s;`
`1684`		`- }`
`1685`		`-`
`1686`	`1679`	`.source .sidebar.expanded {`
`1687`	`1680`	`width: 300px;`
`1688`	`1681`	`}`