More consistently use the Position type

Author: shepmaster

ui/frontend/AdvancedEditor.tsx

@@ -2,7 +2,7 @@ import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react'
 import { connect } from 'react-redux';
 
 import State from './state';
-import { CommonEditorProps, Crate, Edition, Focus, PairCharacters } from './types';
+import { CommonEditorProps, Crate, Edition, Focus, PairCharacters, Position } from './types';
 
 type Ace = typeof import('ace-builds');
 type AceEditor = import('ace-builds').Ace.Editor;
@@ -63,10 +63,7 @@ interface AdvancedEditorProps {
   execute: () => any;
   keybinding?: string;
   onEditCode: (_: string) => any;
-  position: {
-    line: number;
-    column: number;
-  };
+  position: Position;
   theme: string;
   crates: Crate[];
   focus?: Focus;
@@ -297,10 +294,7 @@ interface AdvancedEditorAsyncProps {
   execute: () => any;
   keybinding?: string;
   onEditCode: (_: string) => any;
-  position: {
-    line: number;
-    column: number;
-  };
+  position: Position;
   theme: string;
   crates: Crate[];
   focus?: Focus;

ui/frontend/Editor.tsx

@@ -3,7 +3,7 @@ import { useSelector, useDispatch } from 'react-redux';
 
 import * as actions from './actions';
 import AdvancedEditor from './AdvancedEditor';
-import { CommonEditorProps, Editor as EditorType } from './types';
+import { CommonEditorProps, Editor as EditorType, Position } from './types';
 import { State } from './reducers';
 
 class SimpleEditor extends React.PureComponent<CommonEditorProps> {
@@ -37,7 +37,7 @@ class SimpleEditor extends React.PureComponent<CommonEditorProps> {
     this.gotoPosition(prevProps.position, this.props.position);
   }
 
-  private gotoPosition(oldPosition, newPosition) {
+  private gotoPosition(oldPosition: Position, newPosition: Position) {
     const editor = this._editor;
 
     if (!newPosition || !editor) { return; }

ui/frontend/actions.ts

@@ -429,7 +429,7 @@ export const addImport = (code: string) =>
 export const enableFeatureGate = (featureGate: string) =>
   createAction(ActionType.EnableFeatureGate, { featureGate });
 
-export const gotoPosition = (line, column) =>
+export const gotoPosition = (line: string | number, column: string | number) =>
   createAction(ActionType.GotoPosition, { line: +line, column: +column });
 
 const requestFormat = () =>