Skip to content

Conversation

@mookid
Copy link
Contributor

@mookid mookid commented Apr 12, 2020

fix #365
The issue seems to be that in case of whitespace issues, rustfmt emits the message

error[internal]: left behind trailing whitespace
  --> stdin:13:13:0
   |
13 |                 
   | ^^^^^^^^^^^^^^^^
   |

warning: rustfmt has failed to format. See previous 1 errors.

and the replacement code that looks for ":" fails to replace the reference. As a consequence, the code that jumps to the error pops a new buffer, which is wrong.

cc @xaon @Dushistov

mookid added 2 commits April 12, 2020 17:43
Otherwise it might not be clear what the problem is, in case of
whitespace issues.
@rust-highfive
Copy link

r? @brotzeit

(rust_highfive has picked a reviewer for you, use r? to override)

@mookid mookid merged commit 7fd78f0 into rust-lang:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"rust-format-on-save" sometimes leads to a "stdin" buffer

3 participants