Update known problems for default_numeric_fallback #13794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing known problem is not actually true, and the many false positives and false negatives should be mentioned.
Collaborator
rustbot
added
the
S-waiting-on-review
Centri3
approved these changes
Dec 8, 2024
Member
Centri3
left a comment
Centri3
left a comment
There was a problem hiding this comment.
I presume this was added because it used to not use span_lint_hir_and_then. Thanks, good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing known problem is not actually true, and the many false positives and false negatives should be mentioned.
Allowing the lint on a single statement: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=328de43690af13ed126f7c00c15cd695
changelog: [
default_numeric_fallback]: update known problems docs