Skip to content

inconsistent_struct_constructor is not useful enough #7248

@Fishrock123

Description

@Fishrock123

I do not want to ever have to think about this, because it does not matter and is not useful:

warning: struct constructor field order is inconsistent with struct definition field order
  --> src/main.rs:85:12
   |
85 |           Ok(Self {
   |  ____________^
86 | |             slack_authorization,
87 | |             redis_connection,
88 | |             expiry,
89 | |             slack_client,
90 | |         })
   | |_________^ help: try: `Self { slack_authorization, expiry, redis_connection, slack_client }`
   |
   = note: `#[warn(clippy::inconsistent_struct_constructor)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_struct_constructor

If this should be anywhere, it should be in rustfmt, so it can just get automatically applied and so that I don't waste my time on this.

At very most, this should be pedantic and not a warning by default.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions