Remove the tons of allows

Author: Centri3

CHANGELOG.md

@@ -5465,5 +5465,5 @@ Released 2018-09-13
 [`accept-comment-above-attributes`]: https://doc.rust-lang.org/clippy/lint_configuration.html#accept-comment-above-attributes
 [`allow-one-hash-in-raw-strings`]: https://doc.rust-lang.org/clippy/lint_configuration.html#allow-one-hash-in-raw-strings
 [`absolute-symbol-paths-max-segments`]: https://doc.rust-lang.org/clippy/lint_configuration.html#absolute-symbol-paths-max-segments
-[`absolute-symbol-paths-allow-std`]: https://doc.rust-lang.org/clippy/lint_configuration.html#absolute-symbol-paths-allow-std
+[`absolute-symbol-paths-allowed-crates`]: https://doc.rust-lang.org/clippy/lint_configuration.html#absolute-symbol-paths-allowed-crates
 <!-- end autogenerated links to configuration documentation -->

book/src/lint_configuration.md

@@ -740,10 +740,10 @@ The maximum number of segments a path can have before being linted
 * [`absolute_symbol_paths`](https://rust-lang.github.io/rust-clippy/master/index.html#absolute_symbol_paths)
 
 
-## `absolute-symbol-paths-allow-std`
-Whether to allow paths originating from `core`/`std`/`alloc`
+## `absolute-symbol-paths-allowed-crates`
+Which crates to allow absolute symbols, `crate` will allow the local crate
 
-**Default Value:** `false` (`bool`)
+**Default Value:** `{}` (`rustc_data_structures::fx::FxHashSet<String>`)
 
 ---
 **Affected lints:**

clippy_lints/src/absolute_symbol_paths.rs

@@ -10,13 +10,16 @@ use rustc_span::symbol::kw;
 
 declare_clippy_lint! {
     /// ### What it does
-    /// Checks for usage of symbols through absolute paths, like `std::env::current_dir`.
+    /// Checks for usage of items through absolute paths, like `std::env::current_dir`.
     ///
     /// ### Why is this bad?
     /// Many codebases have their own style when it comes to symbol importing, but one that is
     /// seldom used is using absolute paths *everywhere*. This is generally considered unidiomatic,
     /// and you should add a `use` statement.
     ///
+    /// The default maximum segments (2) is pretty strict, you may want to increase this in
+    /// clippy.toml.
+    ///
     /// Note: One exception to this is code from macro expansion - this does not lint such cases, as
     /// using absolute paths is the proper way of referencing symbols in one.
     ///

clippy_lints/src/lib.rs

@@ -10,11 +10,7 @@
 #![feature(stmt_expr_attributes)]
 #![recursion_limit = "512"]
 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
-#![allow(
-    clippy::absolute_symbol_paths,
-    clippy::missing_docs_in_private_items,
-    clippy::must_use_candidate
-)]
+#![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
 #![warn(trivial_casts, trivial_numeric_casts)]
 // warn on lints, that are included in `rust-lang/rust`s bootstrap
 #![warn(rust_2018_idioms, unused_lifetimes)]

clippy_lints/src/utils/conf.rs

@@ -553,8 +553,9 @@ define_Conf! {
     (allow_one_hash_in_raw_strings: bool = false),
     /// Lint: ABSOLUTE_SYMBOL_PATHS.
     ///
-    /// The maximum number of segments a path can have before being linted
-    (absolute_symbol_paths_max_segments: u64 = 3),
+    /// The maximum number of segments a path can have before being linted, anything above this will
+    /// be linted.
+    (absolute_symbol_paths_max_segments: u64 = 2),
     /// Lint: ABSOLUTE_SYMBOL_PATHS.
     ///
     /// Which crates to allow absolute symbols, `crate` will allow the local crate

clippy_utils/src/check_proc_macro.rs

@@ -354,7 +354,7 @@ pub trait WithSearchPat<'cx> {
     fn span(&self) -> Span;
 }
 macro_rules! impl_with_search_pat {
-    ($cx:ident: $ty:ident with $fn:ident $(($tcx:ident))? && $span_method:ident$($par:tt)?) => {
+    ($cx:ident: $ty:ident with $fn:ident $(($tcx:ident))?) => {
         impl<'cx> WithSearchPat<'cx> for $ty<'cx> {
             type Context = $cx<'cx>;
             #[allow(unused_variables)]
@@ -363,19 +363,18 @@ macro_rules! impl_with_search_pat {
                 $fn($($tcx,)? self)
             }
             fn span(&self) -> Span {
-                self.$span_method$($par)?
+                self.span
             }
         }
     };
 }
-impl_with_search_pat!(LateContext: Expr with expr_search_pat(tcx) && span);
-impl_with_search_pat!(LateContext: Item with item_search_pat && span);
-impl_with_search_pat!(LateContext: TraitItem with trait_item_search_pat && span);
-impl_with_search_pat!(LateContext: ImplItem with impl_item_search_pat && span);
-impl_with_search_pat!(LateContext: FieldDef with field_def_search_pat && span);
-impl_with_search_pat!(LateContext: Variant with variant_search_pat && span);
-impl_with_search_pat!(LateContext: Ty with ty_search_pat && span);
-impl_with_search_pat!(LateContext: QPath with qpath_search_pat && span());
+impl_with_search_pat!(LateContext: Expr with expr_search_pat(tcx));
+impl_with_search_pat!(LateContext: Item with item_search_pat);
+impl_with_search_pat!(LateContext: TraitItem with trait_item_search_pat);
+impl_with_search_pat!(LateContext: ImplItem with impl_item_search_pat);
+impl_with_search_pat!(LateContext: FieldDef with field_def_search_pat);
+impl_with_search_pat!(LateContext: Variant with variant_search_pat);
+impl_with_search_pat!(LateContext: Ty with ty_search_pat);
 
 impl<'cx> WithSearchPat<'cx> for (&FnKind<'cx>, &Body<'cx>, HirId, Span) {
     type Context = LateContext<'cx>;

tests/ui-cargo/module_style/fail_mod/src/main.rs

@@ -1,4 +1,3 @@
-#![allow(clippy::absolute_symbol_paths)]
 #![warn(clippy::self_named_module_files)]
 
 mod bad;

tests/ui-internal/interning_defined_symbol.fixed

@@ -1,10 +1,6 @@
 //@run-rustfix
 #![deny(clippy::internal)]
-#![allow(
-    clippy::absolute_symbol_paths,
-    clippy::missing_clippy_version_attribute,
-    clippy::let_unit_value
-)]
+#![allow(clippy::missing_clippy_version_attribute, clippy::let_unit_value)]
 #![feature(rustc_private)]
 
 extern crate rustc_span;

tests/ui-internal/interning_defined_symbol.rs

@@ -1,10 +1,6 @@
 //@run-rustfix
 #![deny(clippy::internal)]
-#![allow(
-    clippy::absolute_symbol_paths,
-    clippy::missing_clippy_version_attribute,
-    clippy::let_unit_value
-)]
+#![allow(clippy::missing_clippy_version_attribute, clippy::let_unit_value)]
 #![feature(rustc_private)]
 
 extern crate rustc_span;

tests/ui-internal/interning_defined_symbol.stderr

@@ -1,5 +1,5 @@
 error: interning a defined symbol
-  --> $DIR/interning_defined_symbol.rs:22:13
+  --> $DIR/interning_defined_symbol.rs:18:13
    |
 LL |     let _ = Symbol::intern("f32");
    |             ^^^^^^^^^^^^^^^^^^^^^ help: try: `rustc_span::sym::f32`
@@ -12,19 +12,19 @@ LL | #![deny(clippy::internal)]
    = note: `#[deny(clippy::interning_defined_symbol)]` implied by `#[deny(clippy::internal)]`
 
 error: interning a defined symbol
-  --> $DIR/interning_defined_symbol.rs:25:13
+  --> $DIR/interning_defined_symbol.rs:21:13
    |
 LL |     let _ = sym!(f32);
    |             ^^^^^^^^^ help: try: `rustc_span::sym::f32`
 
 error: interning a defined symbol
-  --> $DIR/interning_defined_symbol.rs:28:13
+  --> $DIR/interning_defined_symbol.rs:24:13
    |
 LL |     let _ = Symbol::intern("proc-macro");
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rustc_span::sym::proc_dash_macro`
 
 error: interning a defined symbol
-  --> $DIR/interning_defined_symbol.rs:31:13
+  --> $DIR/interning_defined_symbol.rs:27:13
    |
 LL |     let _ = Symbol::intern("self");
    |             ^^^^^^^^^^^^^^^^^^^^^^ help: try: `rustc_span::symbol::kw::SelfLower`