Skip to content

Commit 53fd302

Browse files
doc_comments_missing_terminal_punctuation: short-circuit to avoid parsing
1 parent 2ec2671 commit 53fd302

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

clippy_lints/src/doc/doc_comments_missing_terminal_punctuation.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@ pub fn check(cx: &LateContext<'_>, doc: &str, fragments: Fragments<'_>) {
4747
fn is_missing_punctuation(doc_string: &str) -> IsMissingPunctuation {
4848
const TERMINAL_PUNCTUATION_MARKS: &[char] = &['.', '?', '!', '…'];
4949

50+
// Short-circuit in simple, common cases to avoid Markdown parsing.
51+
if doc_string.trim_end().ends_with(TERMINAL_PUNCTUATION_MARKS) {
52+
return IsMissingPunctuation::No;
53+
}
54+
5055
let mut no_report_depth = 0;
5156
let mut missing_punctuation = IsMissingPunctuation::No;
5257
for (event, offset) in

0 commit comments

Comments
 (0)