fix: do not emit clippy::toplevel_ref_arg if clippy::ref_pattern is enabled

Author: NotAPenguin0

clippy_lints/src/misc.rs

@@ -16,9 +16,12 @@ use rustc_span::source_map::{ExpnKind, Span};
 
 use clippy_utils::sugg::Sugg;
 use clippy_utils::{
-    get_parent_expr, in_constant, is_integer_literal, is_no_std_crate, iter_input_pats, last_path_segment, SpanlessEq,
+    get_parent_expr, in_constant, is_integer_literal, is_lint_allowed, is_no_std_crate, iter_input_pats,
+    last_path_segment, SpanlessEq,
 };
 
+use crate::ref_pattern::REF_PATTERN;
+
 declare_clippy_lint! {
     /// ### What it does
     /// Checks for function arguments and let bindings denoted as
@@ -162,6 +165,10 @@ impl<'tcx> LateLintPass<'tcx> for LintPass {
             return;
         }
         for arg in iter_input_pats(decl, body) {
+            // Do not emit if clippy::ref_pattern is not allowed to avoid having two lints for the same issue.
+            if !is_lint_allowed(cx, REF_PATTERN, arg.pat.hir_id) {
+                return;
+            }
             if let PatKind::Binding(BindingAnnotation(ByRef::Yes, _), ..) = arg.pat.kind {
                 span_lint(
                     cx,
@@ -180,6 +187,8 @@ impl<'tcx> LateLintPass<'tcx> for LintPass {
             if let StmtKind::Local(local) = stmt.kind;
             if let PatKind::Binding(BindingAnnotation(ByRef::Yes, mutabl), .., name, None) = local.pat.kind;
             if let Some(init) = local.init;
+            // Do not emit if clippy::ref_pattern is not allowed to avoid having two lints for the same issue.
+            if is_lint_allowed(cx, REF_PATTERN, local.pat.hir_id);
             then {
                 let ctxt = local.span.ctxt();
                 let mut app = Applicability::MachineApplicable;
@@ -220,6 +229,8 @@ impl<'tcx> LateLintPass<'tcx> for LintPass {
             if let ExprKind::Binary(ref binop, a, b) = expr.kind;
             if binop.node == BinOpKind::And || binop.node == BinOpKind::Or;
             if let Some(sugg) = Sugg::hir_opt(cx, a);
+            // Do not emit if clippy::ref_pattern is not allowed to avoid having two lints for the same issue.
+            if is_lint_allowed(cx, REF_PATTERN, expr.hir_id);
             then {
                 span_lint_hir_and_then(
                     cx,
@@ -252,6 +263,10 @@ impl<'tcx> LateLintPass<'tcx> for LintPass {
             // Don't lint things expanded by #[derive(...)], etc or `await` desugaring
             return;
         }
+        // Do not emit if clippy::ref_pattern is not allowed to avoid having two lints for the same issue.
+        if !is_lint_allowed(cx, REF_PATTERN, expr.hir_id) {
+            return;
+        }
         let sym;
         let binding = match expr.kind {
             ExprKind::Path(ref qpath) if !matches!(qpath, hir::QPath::LangItem(..)) => {

tests/ui/ref_pattern.rs

@@ -1,5 +1,4 @@
 #![allow(unused)]
-#![allow(clippy::toplevel_ref_arg)]
 #![warn(clippy::ref_pattern)]
 
 fn use_in_pattern() {
@@ -15,4 +14,6 @@ fn use_in_binding() {
     let ref y = x;
 }
 
+fn use_in_parameter(ref x: i32) {}
+
 fn main() {}

tests/ui/ref_pattern.stderr

@@ -1,5 +1,5 @@
 error: usage of ref pattern
-  --> $DIR/ref_pattern.rs:9:14
+  --> $DIR/ref_pattern.rs:8:14
    |
 LL |         Some(ref opt) => {},
    |              ^^^^^^^
@@ -8,12 +8,20 @@ LL |         Some(ref opt) => {},
    = note: `-D clippy::ref-pattern` implied by `-D warnings`
 
 error: usage of ref pattern
-  --> $DIR/ref_pattern.rs:15:9
+  --> $DIR/ref_pattern.rs:14:9
    |
 LL |     let ref y = x;
    |         ^^^^^
    |
    = help: consider using `&` for clarity instead
 
-error: aborting due to 2 previous errors
+error: usage of ref pattern
+  --> $DIR/ref_pattern.rs:17:21
+   |
+LL | fn use_in_parameter(ref x: i32) {}
+   |                     ^^^^^
+   |
+   = help: consider using `&` for clarity instead
+
+error: aborting due to 3 previous errors