Skip to content

Commit a0bb2ce

Browse files
committed
Rename ir::traversal::TypeCollector to ir::traversal::Trace
And its `collect_types` method to `trace`.
1 parent b94b271 commit a0bb2ce

File tree

6 files changed

+23
-23
lines changed

6 files changed

+23
-23
lines changed

src/ir/comp.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use super::derive::{CanDeriveCopy, CanDeriveDebug, CanDeriveDefault};
66
use super::item::{Item, ItemSet};
77
use super::layout::Layout;
88
use super::ty::{TemplateDeclaration, Type};
9-
use super::traversal::TypeCollector;
9+
use super::traversal::Trace;
1010
use clang;
1111
use parse::{ClangItemParser, ParseError};
1212
use std::cell::Cell;
@@ -1075,10 +1075,10 @@ impl<'a> CanDeriveCopy<'a> for CompInfo {
10751075
}
10761076
}
10771077

1078-
impl TypeCollector for CompInfo {
1078+
impl Trace for CompInfo {
10791079
type Extra = Item;
10801080

1081-
fn collect_types(&self,
1081+
fn trace(&self,
10821082
context: &BindgenContext,
10831083
types: &mut ItemSet,
10841084
item: &Item) {

src/ir/context.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use super::int::IntKind;
55
use super::item::{Item, ItemSet, ItemCanonicalPath};
66
use super::item_kind::ItemKind;
77
use super::module::{Module, ModuleKind};
8-
use super::traversal::{ItemTraversal, TypeCollector};
8+
use super::traversal::{ItemTraversal, Trace};
99
use super::ty::{FloatKind, TemplateDeclaration, Type, TypeKind};
1010
use BindgenOptions;
1111
use cexpr;
@@ -1393,7 +1393,7 @@ impl<'ctx, 'gen> Iterator for AssertNoDanglingItemIter<'ctx, 'gen>
13931393
};
13941394

13951395
let mut sub_types = ItemSet::new();
1396-
id.collect_types(self.ctx, &mut sub_types, &());
1396+
id.trace(self.ctx, &mut sub_types, &());
13971397

13981398
if self.ctx.resolve_item_fallible(id).is_none() {
13991399
let mut path = vec![];

src/ir/function.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
use super::context::{BindgenContext, ItemId};
44
use super::item::{Item, ItemSet};
55
use super::ty::TypeKind;
6-
use super::traversal::TypeCollector;
6+
use super::traversal::Trace;
77
use clang;
88
use clang_sys::CXCallingConv;
99
use parse::{ClangItemParser, ClangSubItemParser, ParseError, ParseResult};
@@ -316,10 +316,10 @@ impl ClangSubItemParser for Function {
316316
}
317317
}
318318

319-
impl TypeCollector for FunctionSig {
319+
impl Trace for FunctionSig {
320320
type Extra = Item;
321321

322-
fn collect_types(&self,
322+
fn trace(&self,
323323
_context: &BindgenContext,
324324
types: &mut ItemSet,
325325
_item: &Item) {

src/ir/item.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use super::function::Function;
77
use super::item_kind::ItemKind;
88
use super::module::Module;
99
use super::ty::{TemplateDeclaration, Type, TypeKind};
10-
use super::traversal::TypeCollector;
10+
use super::traversal::Trace;
1111
use clang;
1212
use clang_sys;
1313
use parse::{ClangItemParser, ClangSubItemParser, ParseError, ParseResult};
@@ -167,21 +167,21 @@ impl ItemAncestors for Item {
167167
}
168168
}
169169

170-
impl TypeCollector for ItemId {
170+
impl Trace for ItemId {
171171
type Extra = ();
172172

173-
fn collect_types(&self,
173+
fn trace(&self,
174174
ctx: &BindgenContext,
175175
types: &mut ItemSet,
176176
extra: &()) {
177-
ctx.resolve_item(*self).collect_types(ctx, types, extra);
177+
ctx.resolve_item(*self).trace(ctx, types, extra);
178178
}
179179
}
180180

181-
impl TypeCollector for Item {
181+
impl Trace for Item {
182182
type Extra = ();
183183

184-
fn collect_types(&self,
184+
fn trace(&self,
185185
ctx: &BindgenContext,
186186
types: &mut ItemSet,
187187
_extra: &()) {
@@ -196,7 +196,7 @@ impl TypeCollector for Item {
196196
// opaque.
197197
if ty.should_be_traced_unconditionally() ||
198198
!self.is_opaque(ctx) {
199-
ty.collect_types(ctx, types, self);
199+
ty.trace(ctx, types, self);
200200
}
201201
}
202202
ItemKind::Function(ref fun) => {

src/ir/traversal.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ use super::context::{BindgenContext, ItemId};
44
use super::item::ItemSet;
55

66
/// Collect all the type items referenced by this item.
7-
pub trait TypeCollector {
7+
pub trait Trace {
88
/// If a particular type needs extra information beyond what it has in
99
/// `self` and `context` to find its referenced type items, its
1010
/// implementation can define this associated type, forcing callers to pass
1111
/// the needed information through.
1212
type Extra;
1313

1414
/// Add each type item referenced by `self` into the `types` set.
15-
fn collect_types(&self,
15+
fn trace(&self,
1616
context: &BindgenContext,
1717
types: &mut ItemSet,
1818
extra: &Self::Extra);
@@ -78,7 +78,7 @@ impl<'ctx, 'gen> Iterator for ItemTraversal<'ctx, 'gen>
7878

7979
if self.ctx.options().whitelist_recursively {
8080
let mut sub_types = ItemSet::new();
81-
id.collect_types(self.ctx, &mut sub_types, &());
81+
id.trace(self.ctx, &mut sub_types, &());
8282

8383
for id in sub_types {
8484
if self.seen.insert(id) {

src/ir/ty.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use super::int::IntKind;
99
use super::item::{Item, ItemSet};
1010
use super::layout::Layout;
1111
use super::objc::ObjCInterface;
12-
use super::traversal::TypeCollector;
12+
use super::traversal::Trace;
1313
use clang::{self, Cursor};
1414
use parse::{ClangItemParser, ParseError, ParseResult};
1515
use std::mem;
@@ -1125,10 +1125,10 @@ impl Type {
11251125
}
11261126
}
11271127

1128-
impl TypeCollector for Type {
1128+
impl Trace for Type {
11291129
type Extra = Item;
11301130

1131-
fn collect_types(&self,
1131+
fn trace(&self,
11321132
context: &BindgenContext,
11331133
types: &mut ItemSet,
11341134
item: &Item) {
@@ -1148,9 +1148,9 @@ impl TypeCollector for Type {
11481148
types.insert(item);
11491149
}
11501150
}
1151-
TypeKind::Comp(ref ci) => ci.collect_types(context, types, item),
1151+
TypeKind::Comp(ref ci) => ci.trace(context, types, item),
11521152
TypeKind::Function(ref sig) => {
1153-
sig.collect_types(context, types, item)
1153+
sig.trace(context, types, item)
11541154
}
11551155
TypeKind::Enum(ref en) => {
11561156
if let Some(repr) = en.repr() {

0 commit comments

Comments
 (0)